solution to problem 551 from project euler #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Aug 31, 2019
project_euler/problem_551/sol1.py
Outdated
| for j in range(k): | ||
| s = a_i[j] + addend | ||
| a_i[j] = s % 10 | ||
| addend = s // 10 |
There was a problem hiding this comment.
Combine 131 and 132 into a single line with builtin divmod():
addend, a_i[j] = divmod(s, 10)
There was a problem hiding this comment.
nice! also changed it in a few more places
cclauss
requested changes
Aug 31, 2019
|
My bad, changed some of the less descriptive names and also added some comments to aid readability. |
cclauss
approved these changes
Sep 1, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* solution to problem 551 from project euler * renamed variables, and added more comments to improve readabilty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This would be my first contribution, so if there is anything I could have done better, I would greatly appreciate any feedback.
Thanks!