Skip to content

adding the remove digit algorithm #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisO345 merged 10 commits into from
May 10, 2023
Merged

adding the remove digit algorithm #6708

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f97cda9
adding the remove digit algorithm
meg-1 Oct 5, 2022
b9013e5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2022
d4d1ef8
refactoring code
meg-1 Oct 12, 2022
c4b81c2
Apply suggestions from code review
cclauss Oct 30, 2022
a4a47ab
Update remove_digit.py
cclauss Oct 30, 2022
2e1aa1a
fixing errors
meg-1 Nov 16, 2022
a493d79
fixing error C416
meg-1 Nov 16, 2022
80372da
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 16, 2022
96c317a
implementing contributors suggestions
meg-1 Nov 23, 2022
05f4d71
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
implementing contributors suggestions
  • Loading branch information
@meg-1
meg-1 committed Nov 23, 2022
commit 96c317a89da45a3c8b2db5a885ca944eb2540362
13 changes: 6 additions & 7 deletions maths/remove_digit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,16 @@ def remove_digit(num: int) -> int:
TypeError: only integers accepted as input
"""

if isinstance(num, int):
if not isinstance(num, int):
raise TypeError("only integers accepted as input")
else:
num_str = str(abs(num))
num_transpositions = [list(num_str) for char in range(len(num_str))]
for index in range(len(num_str)):
num_transpositions[index].pop(index)
return sorted(
(int("".join(list(transposition))) for transposition in num_transpositions),
reverse=True,
)[0]
else:
raise TypeError("only integers accepted as input")
return max(
(int("".join(list(transposition))) for transposition in num_transpositions)
)


if __name__ == "__main__":
Expand Down