improved function accuracy and added test case

maths/maclaurin_sin.py

@@ -1,7 +1,7 @@
 """
 https://en.wikipedia.org/wiki/Taylor_series#Trigonometric_functions
 """
-from math import factorial
+from math import factorial, pi
 
 
 def maclaurin_sin(theta: float, accuracy: int = 30) -> float:
@@ -12,14 +12,18 @@ def maclaurin_sin(theta: float, accuracy: int = 30) -> float:
     :param accuracy: the degree of accuracy wanted minimum ~ 1.5 theta
     :return: the value of sine in radians
 
+
+    >>> from math import isclose, sin
+    >>> all(isclose(maclaurin_sin(x, 50), sin(x)) for x in range(-25, 25))
+    True
     >>> maclaurin_sin(10)
-    -0.54402111088927
+    -0.544021110889369
     >>> maclaurin_sin(-10)
-    0.54402111088927
+    0.5440211108893703
     >>> maclaurin_sin(10, 15)
-    -0.5429111519640644
+    -0.5440211108893689
     >>> maclaurin_sin(-10, 15)
-    0.5429111519640644
+    0.5440211108893703
     >>> maclaurin_sin("10")
     Traceback (most recent call last):
     ...
@@ -39,18 +43,28 @@ def maclaurin_sin(theta: float, accuracy: int = 30) -> float:
     """
 
     if not isinstance(theta, (int, float)):
-        raise ValueError("maclaurin_sin() requires either an int or float for theta")
+        raise ValueError(
+            "maclaurin_sin() requires either an int or float for theta"
+        )
 
     if not isinstance(accuracy, int) or accuracy <= 0:
-        raise ValueError("maclaurin_sin() requires a positive int for accuracy")
+        raise ValueError(
+            "maclaurin_sin() requires a positive int for accuracy"
+        )
 
     theta = float(theta)
 
+    div = theta // (2 * pi)
+    theta = theta - (2 * div * pi)
+
     total = 0
     for r in range(accuracy):
         total += ((-1) ** r) * ((theta ** (2 * r + 1)) / (factorial(2 * r + 1)))
-    return float(total)
+    return total
 
 
 if __name__ == "__main__":
+    print(maclaurin_sin(10))
+    print(maclaurin_sin(-10))
     print(maclaurin_sin(10, 15))
+    print(maclaurin_sin(-10, 15))