-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Update advanced_selectors.md: remove redundant expression "finely grained" #30113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
"specific" and "finely grained" mean the same thing so it's probably enough to have one. "specific" is shorter, so I chose that version. Also, if keeping "finely grained" is desired, it might be better to change it to the idiomatic form which is "fine-grained way" rather than "finely grained way".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - please see the comment below.
Also, not something you've done, just an existing issue, but while you're at it, would you giving the note box at line 101 an appropriate heading? Something like #### Specificity notation
or similar.
The heading must be surrounded by a single blank line each side and must not be indented. See this repo's layout style guide for more info.
intermediate_html_css/intermediate_css_concepts/advanced_selectors.md
Outdated
Show resolved
Hide resolved
- changed "specific" to "more fine-grained" per mao-sz's request - add the missing h4 header to the lesson note per the layout guide https://github.com/TheOdinProject/curriculum/blob/main/LAYOUT_STYLE_GUIDE.md#note-boxes - layout guide pointed out the correct markdown attribute is markdown="1", so I added missing quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please let me know if I correctly submitted a new commit to my pull request for you to review? This is new for me, and I'm not sure I did it right.
intermediate_html_css/intermediate_css_concepts/advanced_selectors.md
Outdated
Show resolved
Hide resolved
|
||
The (0,0,1,0) above is the notation for calculating specificity. To find out more about how it works, glance over the "Calculating CSS Specificity Value" section from this [article on CSS Specificity](https://css-tricks.com/specifics-on-css-specificity/). | ||
#### Calculating CSS Specificity notation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thank you! Well, just the tiny change needed here since our style guide wants headings to be in sentence case. Once that's changed, we'll be good to merge.
#### Calculating CSS Specificity notation | |
#### Calculating CSS specificity notation |
Because
"specific" and "finely grained" mean the same thing so it's probably enough to have one. "specific" is shorter, so I chose that version.
This PR
Issue
It's a tiny word choice suggestion. "finely grained" doesn't sound correct. It might be better to change it to the idiomatic form, which is "fine-grained way" rather than "finely grained way". But I suggest removing it altogether because "specific" is pointing to the same meaning.
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section