Skip to content

Conversation

annarider
Copy link

Because

"specific" and "finely grained" mean the same thing so it's probably enough to have one. "specific" is shorter, so I chose that version.

This PR

  • I removed "and finely grained" from the lesson

Issue

It's a tiny word choice suggestion. "finely grained" doesn't sound correct. It might be better to change it to the idiomatic form, which is "fine-grained way" rather than "finely grained way". But I suggest removing it altogether because "specific" is pointing to the same meaning.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

"specific" and "finely grained" mean the same thing so it's probably enough to have one. "specific" is shorter, so I chose that version. 

Also, if keeping "finely grained" is desired, it might be better to change it to the idiomatic form which is "fine-grained way" rather than "finely grained way".
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Sep 11, 2025
Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - please see the comment below.

Also, not something you've done, just an existing issue, but while you're at it, would you giving the note box at line 101 an appropriate heading? Something like #### Specificity notation or similar.
The heading must be surrounded by a single blank line each side and must not be indented. See this repo's layout style guide for more info.

- changed "specific" to "more fine-grained" per mao-sz's request
- add the missing h4 header to the lesson note per the layout guide https://github.com/TheOdinProject/curriculum/blob/main/LAYOUT_STYLE_GUIDE.md#note-boxes
- layout guide pointed out the correct markdown attribute is markdown="1", so I added missing quotes
Copy link
Author

@annarider annarider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please let me know if I correctly submitted a new commit to my pull request for you to review? This is new for me, and I'm not sure I did it right.


The (0,0,1,0) above is the notation for calculating specificity. To find out more about how it works, glance over the "Calculating CSS Specificity Value" section from this [article on CSS Specificity](https://css-tricks.com/specifics-on-css-specificity/).
#### Calculating CSS Specificity notation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you! Well, just the tiny change needed here since our style guide wants headings to be in sentence case. Once that's changed, we'll be good to merge.

Suggested change
#### Calculating CSS Specificity notation
#### Calculating CSS specificity notation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants