Skip to content

"controls" support for ios & "fullscreen" support for Android #369

@louislai

Description

@louislai

Right now, react-native-video supports opening a fullscreen player on ios using presentFullScreenPlayer, but this option is missing in android. Similarly, I can toggle a native player controls using the controls prop, but this only works on Android.
Would be really nice if someone can implement native controls in iOS, and fullscreen player for Android inside the react-native-video package.

I tried to hack together a fullscreen player for android by creating a new Activity with a SurfaceView to display the video output. To stop the video from reloading I store the MediaPlayer object as a singleton https://github.com/louislai/react-native-video/blob/master/android/src/main/java/com/brentvatne/react/FullScreenVideoActivity.java
However, I hope that someone can give a more general and proper solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleClosed due to inactivity or lack or resources

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions