Skip to content

Add allowsExternalPlayback Property for ios #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cobarx merged 6 commits into from
Jun 10, 2018
Merged

Add allowsExternalPlayback Property for ios #1057

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e79e447
Add allowsExternalPlayback property to control external playback
Jun 6, 2018
b83fda9
Add allowsExternalPlayback to video for ios
Jun 6, 2018
7460df9
Merge branch 'master' into master
genglei01 Jun 8, 2018
6f5211f
remove indentation
genglei01 Jun 10, 2018
187158b
add an entry in the README for allowsExternalPlayback property
Jun 10, 2018
36dffa6
Reorder allowsExternalPlayback alphabetically
cobarx Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add allowsExternalPlayback property to control external playback
  • Loading branch information
LeoGeng committed Jun 6, 2018
commit e79e447375f26027510f3aaa84b2f916e2c45b3c
9 changes: 9 additions & 0 deletions ios/RCTVideo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ @implementation RCTVideo
BOOL _muted;
BOOL _paused;
BOOL _repeat;
BOOL _allowsExternalPlayback;
BOOL _playbackStalled;
BOOL _playInBackground;
BOOL _playWhenInactive;
Expand All @@ -66,6 +67,7 @@ - (instancetype)initWithEventDispatcher:(RCTEventDispatcher *)eventDispatcher
_controls = NO;
_playerBufferEmpty = YES;
_playInBackground = false;
_allowsExternalPlayback = YES;
Copy link
Contributor

@cobarx cobarx Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off here.

_playWhenInactive = false;
_ignoreSilentSwitch = @"inherit"; // inherit, ignore, obey

Expand Down Expand Up @@ -522,6 +524,12 @@ - (void)setPlayInBackground:(BOOL)playInBackground
_playInBackground = playInBackground;
}

- (void)setAllowsExternalPlayback:(BOOL)allowsExternalPlayback
{
_allowsExternalPlayback = allowsExternalPlayback;
_player.allowsExternalPlayback = _allowsExternalPlayback;
}

- (void)setPlayWhenInactive:(BOOL)playWhenInactive
{
_playWhenInactive = playWhenInactive;
Expand Down Expand Up @@ -633,6 +641,7 @@ - (void)applyModifiers
[self setRepeat:_repeat];
[self setPaused:_paused];
[self setControls:_controls];
[self setAllowsExternalPlayback:_allowsExternalPlayback];
}

- (void)setRepeat:(BOOL)repeat {
Expand Down
1 change: 1 addition & 0 deletions ios/RCTVideoManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ - (dispatch_queue_t)methodQueue
RCT_EXPORT_VIEW_PROPERTY(src, NSDictionary);
RCT_EXPORT_VIEW_PROPERTY(resizeMode, NSString);
RCT_EXPORT_VIEW_PROPERTY(repeat, BOOL);
RCT_EXPORT_VIEW_PROPERTY(allowsExternalPlayback, BOOL);
RCT_EXPORT_VIEW_PROPERTY(paused, BOOL);
RCT_EXPORT_VIEW_PROPERTY(muted, BOOL);
RCT_EXPORT_VIEW_PROPERTY(controls, BOOL);
Expand Down