Skip to content

Fixes bug where poster and video was displayed simultaneously #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CHaNGeTe merged 8 commits into from
Jun 22, 2019
Merged

Fixes bug where poster and video was displayed simultaneously #1627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d3936d
Fixes bug where poster and video was displayed simultaneously
jensellfors Jun 19, 2019
cc7db91
Improved handling of poster, fading it out on load
jensellfors Jun 19, 2019
420332e
Implemented onReadyForDisplay for iOS when using controls
jensellfors Jun 19, 2019
b193baa
Hide poster at the right time ie in onReadyForDisplay
jensellfors Jun 19, 2019
e5b5bbe
Updated changelog and readme
jensellfors Jun 19, 2019
fcef441
Added onReadyForDisplay to web/dom
jensellfors Jun 19, 2019
cb3e8c8
Merge branch 'release/4.4.2' into posterfix
jensellfors Jun 20, 2019
6ea6583
Make sure to hide poster for Windows, even though onReadyForDisplay i…
jensellfors Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added onReadyForDisplay to web/dom
  • Loading branch information
@jensellfors
jensellfors committed Jun 19, 2019
commit fcef441369c1840fe46a3ed0326694c7cd76dd40
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,9 @@ Payload: none

* iOS: [readyForDisplay](https://developer.apple.com/documentation/avkit/avplayerviewcontroller/1615830-readyfordisplay?language=objc)
* Android: [MEDIA_INFO_VIDEO_RENDERING_START](https://developer.android.com/reference/android/media/MediaPlayer#MEDIA_INFO_VIDEO_RENDERING_START)
* Android ExoPlayer [STATE_READY](https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/Player.html#STATE_READY)

Platforms: all
Platforms: Android ExoPlayer, Android MediaPlayer, iOS, Web

#### onPictureInPictureStatusChanged
Callback function that is called when picture in picture becomes active or inactive.
Expand Down
6 changes: 6 additions & 0 deletions dom/RCTVideo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class RCTVideo extends RCTView {
this.videoElement = this.initializeVideoElement();
this.videoElement.addEventListener("ended", this.onEnd);
this.videoElement.addEventListener("loadeddata", this.onLoad);
this.videoElement.addEventListener("canplay", this.onReadyForDisplay);
this.videoElement.addEventListener("loadstart", this.onLoadStart);
this.videoElement.addEventListener("pause", this.onPause);
this.videoElement.addEventListener("play", this.onPlay);
Expand All @@ -51,6 +52,7 @@ class RCTVideo extends RCTView {
detachFromView(view: UIView) {
this.videoElement.removeEventListener("ended", this.onEnd);
this.videoElement.removeEventListener("loadeddata", this.onLoad);
this.videoElement.removeEventListener("canplay", this.onReadyForDisplay);
this.videoElement.removeEventListener("loadstart", this.onLoadStart);
this.videoElement.removeEventListener("pause", this.onPause);
this.videoElement.removeEventListener("play", this.onPlay);
Expand Down Expand Up @@ -203,6 +205,10 @@ class RCTVideo extends RCTView {
this.sendEvent("topVideoLoad", payload);
}

onReadyForDisplay = () => {
this.sendEvent("onReadyForDisplay");
}

onLoadStart = () => {
const src = this.videoElement.currentSrc;
const payload = {
Expand Down