data structures #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarv
approved these changes
Jun 14, 2019
Collaborator
samarv
left a comment
samarv
left a comment
There was a problem hiding this comment.
Review for Data Structures Sprint Challenge
Thorben, Good job on the sprint challenge. You have nailed it and solved all the exercises. Your answers to the complexity questions are correct.
You have properly implemented ring buffer and all tests pass. You have also optimized names program and got really fast performance using Binary search trees.
Overview:
Complexity answers correct (MVP)
Ring Buffer implemented (MVP)
Names exercise optimised (MVP)
Take a look at Sets. Intersection between 2 sets is constant time.
Summary
You did amazing job that displayed Your excellent mastery on the subject. Keep up the good work 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.