Skip to content

Conversation

@mrshll1001
Copy link
Contributor

This PR updates the documentation to match the schema changes made in #305 .

Copy link
Contributor

@KDuerden KDuerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked these changes and I'm happy with them. I'm approving this in my capacity as member of 360Giving team, as the first stage in PATCH approval process, which requires sign off from 360Giving team and a member of the Stewardship committee.

If you are adding your own column titles it is best to use simple titles and to avoid special characters which could cause problems in data reuse.

Using only lowercase and uppercase alphabetical characters (``a-z`` and ``A-Z``), numerical digits (``0-9``), colons (``:``), parentheses (``(`` and ``)``) and single spaces will help to avoid problems. Full-stops (``.``) are known to cause issues and should be avoided. Other characters could be used, but haven't been fully tested in all possible situations.
Using only lowercase and uppercase alphabetical characters (``a-z`` and ``A-Z``), numerical digits (``0-9``), colons (``:``), parentheses (``(`` and ``)``) and single spaces will help to avoid problems. Full-stops (``.``) are known to cause issues and should be avoided. Other characters could be used, but haven't been fully tested in all possible situations. `Contact 360Giving support <mailto:[email protected]`_ with further queries about naming your own columns.
Copy link
Contributor

@KDuerden KDuerden Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to:

Contact 360Giving support <mailto:[email protected]>_

ETA - this is now showing the marks around this text but hopefully that makes sense. - it's basically missing closing >

@mrshll1001 mrshll1001 merged commit e8ee286 into master Dec 10, 2021
@mrshll1001 mrshll1001 deleted the 2021-housekeeping branch December 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants