Skip to content

Conversation

@mariongalley
Copy link
Contributor

This PATCH update will update the normative guidance about the Governance and Revision Control process text in the 360Giving Data Standard documentation.

This text has been written by members of the 360Giving team and approved by the Stewardship Committee at the June meeting. This PATCH is to make the agreed changes live in the standard documentation site.

Please can you review this from a technical perspective @mrshll1001? I'll post here once this has been approved.

@mrshll1001
Copy link
Contributor

This is on my list to review first thing tomorrow! Once approved I'll also do the needful and iterate the version number

Copy link
Contributor

@mrshll1001 mrshll1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will proceed with merge and versioning now.

@KDuerden
Copy link
Contributor

@mrshll1001 please don't merge we need to wait to end of the week before sign off

@mrshll1001
Copy link
Contributor

I'll post here once this has been approved.

@mariongalley @KDuerden just checking this is OK to merge in now? It's fine from a technical perspective, I don't see any markdown errors at all, but the wording there has me wondering if we're waiting on something else?

@mrshll1001
Copy link
Contributor

@mrshll1001 please don't merge we need to wait to end of the week before sign off

Aha just ahead of me. I did think there was something!

@KDuerden
Copy link
Contributor

KDuerden commented Jul 14, 2022

I've read and checked this, and I'm happy to sign off on this being merged, if we have no objections, or amends from the SC at the end of the week.

@mariongalley
Copy link
Contributor Author

Yes, they have until end of tomorrow to comment

@mariongalley
Copy link
Contributor Author

It's been a week since I notified the Stewardship Committee so this patch is de facto approved. Please merge @mrshll1001

@mrshll1001 mrshll1001 merged commit d1515e7 into master Aug 22, 2022
@mrshll1001
Copy link
Contributor

I thought I'd done this! Apologies. I've merged now, so will do the needful re iterating the PATCH number.

@mrshll1001 mrshll1001 deleted the update-governance-revision branch August 22, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants