Bring geoTypeCodelist column names in line with other codelists #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with other codelists
michaelwood
approved these changes
Jul 25, 2023
Member
michaelwood
left a comment
michaelwood
left a comment
There was a problem hiding this comment.
No issues for the tools, we'll be able to uncomment out the code that supports this after this is resolved (https://github.com/ThreeSixtyGiving/datastore/blob/master/datastore/additional_data/sources/codelist_code.py#L15)
Contributor
Author
|
Great news! We still need approval from 360G/SC for the PATCH, but that's really good to hear. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348
Changes
NametoTitleto bring in line with other codelists.This doesn't introduce any new features or backwards incompatible changes to the standard.
I think this is a PATCH because it's a backwards compatible bug fix; validation should not be affected at all and tools can expect to behave properly now.
@michaelwood does this create any problems for tooling? Thinking of the fact you mentioned it in /grantnav/#976