Skip to content

Conversation

Thundernerd
Copy link
Owner

Proposed changes

I've recently introduced caching of the reference drawers which broke support for collections. This fix passes the appropriate SerializedProperty along so that this can be used to determine the correct values.

Types of changes

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming)
  • Build related changes (workflow changes)
  • Documentation Update (readme, changelog)
  • Other, please describe:

Issue

#40

What is the current behavior?

When removing an item from a collection it will always remove the last item, instead of the selected item.

What is the new behavior?

When removing an item it now removes the selected item.

Checklist

Put an x in the boxes that apply.

  • The code compiles
  • I have tested that this doesn't break existing code (unless it is an explicit breaking change)
  • I have tested that the (new) functionality/fix works as intended
  • I have added necessary documentation (if appropriate)

@Thundernerd Thundernerd merged commit b732ae2 into main Jul 25, 2022
@Thundernerd Thundernerd deleted the fix/caching_drawers branch July 25, 2022 20:38
@Thundernerd
Copy link
Owner Author

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant