Improve usage with Arrays and Lists #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only invoke Clicked for a Property if the Mouse is in the Property's Rect. In case that the Property was part of an Array all Array Elements were being pinged. This resulted in Unity ignoring all Pings except the last, so it was basically useless.
|
Thanks for the PR! I’ll have a look at it soon :) |
Thundernerd
requested changes
Oct 23, 2023
Co-authored-by: Christiaan Bloemendaal <[email protected]>
Thundernerd
requested changes
Oct 30, 2023
Thundernerd
requested changes
Oct 30, 2023
Co-authored-by: Christiaan Bloemendaal <[email protected]>
Thundernerd
approved these changes
Nov 7, 2023
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make the SerializableInterface work better as an Array or List. Added Extensions Methods to convert an Array/List of Interfaces to a Array/List of SerializableInterface.
Fixed and issue that prevented to set different Values to a Array/List in the Unity Inspector.
Types of changes
Put an
xin the boxes that apply.Issue
None
What is the current behavior?
When having an Array/List of SerializableInterface in the Unity Editor and setting on Element with the Dropdown, all Elements were set to the Selection of the Dropdown.
There was no way to convert a Array/List of Interface to a Array/List of SerializableInterface which would be usefull when populating a SerializableInterface Array/List from an Editor Tool.
What is the new behavior?
When having an Array/List of SerializableInterface in the Unity Editor and setting on Element with the Dropdown, only the selected Element is set to the Selection of the Dropdown
There is a Constructor to create a SerializableInterface from an Interface and also extensions to create Array/Lists
Checklist
Put an
xin the boxes that apply.Further comments
I'm happy to discuss my changes