Skip to content

Overhaul the NuGet packaging infrastructure and the way the Core binaries get acquired. #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo-tsirpanis merged 25 commits into from
Dec 1, 2022
Merged

Overhaul the NuGet packaging infrastructure and the way the Core binaries get acquired. #146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
0c36a4c
Start writing an MSBuild script that creates NuGet packages for the c…
teo-tsirpanis Nov 14, 2022
1d7d3b0
Support creating the native packages.
teo-tsirpanis Nov 14, 2022
61b5178
Support creating the metapackage.
teo-tsirpanis Nov 15, 2022
2a06a80
(REMOVE BEFORE MERGE) Add a temporary MyGet feed for the TileDB nativ…
teo-tsirpanis Nov 15, 2022
b72b8dc
Use the TileDB Embedded page for the project URL in the native packages.
teo-tsirpanis Nov 15, 2022
cad8b05
Use the `TileDB.Native` NuGet package and remove the nuspec of `TileD…
teo-tsirpanis Nov 15, 2022
74a1520
Set `UseCurrentRuntimeIdentifier` in the executable projects.
teo-tsirpanis Nov 15, 2022
2ec7fe9
Restore the template packages.
teo-tsirpanis Nov 15, 2022
287a4ac
Remove the ValueSeparator hack.
teo-tsirpanis Nov 15, 2022
0e4ca34
Remove the "Install/Download tiledb" steps from CI.
teo-tsirpanis Nov 15, 2022
c14741d
Remove all CI jobs except of Run-Tests.
teo-tsirpanis Nov 16, 2022
3c33ffe
Remove RollForward from TileDB.CSharp.
teo-tsirpanis Nov 16, 2022
e655b26
Update package metadata and move them to a dedicated file.
teo-tsirpanis Nov 17, 2022
d0764a6
Add support for generating development editions of the native packages.
teo-tsirpanis Nov 17, 2022
4d85390
Enable Central Package Management with package source mapping.
teo-tsirpanis Nov 17, 2022
f848e09
Add release notes in the packages.
teo-tsirpanis Nov 17, 2022
8869749
Refactor the nightly build workflow to use native development NuGet p…
teo-tsirpanis Nov 17, 2022
fffdd3c
Update the repository README and add a package README.
teo-tsirpanis Nov 17, 2022
4f3601f
Require `Version` and `VersionTag` to be specified.
teo-tsirpanis Nov 17, 2022
f787a3c
Add a README describing the native NuGet package generator.
teo-tsirpanis Nov 17, 2022
abf0603
Demand Core version 2.12.x.
teo-tsirpanis Nov 23, 2022
e456ae3
Warn when building an RID-agnostic executable that uses `TileDB.CSharp`.
teo-tsirpanis Nov 24, 2022
ec1ddab
Remove the RID-specific build instructions in the metapackage's descr…
teo-tsirpanis Nov 24, 2022
24b425d
Remove the MyGet feed; we are now using the official TileDB binaries …
teo-tsirpanis Dec 1, 2022
dd9213a
Use MSBuild's custom item separator feature instead of a `string.Repl…
teo-tsirpanis Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update package metadata and move them to a dedicated file. 
I had originally removed the nuspec files from the native packages but changed my mind for aesthetic reasons since they generate an empty .NET Standard 2.0 dependency group.
  • Loading branch information
@teo-tsirpanis
teo-tsirpanis committed Nov 17, 2022
commit e655b268f58dfd935eef744e0e5968bb7042e8cd
6 changes: 4 additions & 2 deletions scripts/nuget/TileDB.Native.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
<license type="expression">MIT</license>
<icon>logo.png</icon>
<projectUrl>https://tiledb.com/products/tiledb-embedded/</projectUrl>
<repository type="git" url="https://github.com/TileDB-Inc/TileDB" />
<description>The TileDB Embedded library. This is a metapackage that will route to the appropriate native package based on the runtime identifier.</description>
<repository type="git" url="https://github.com/TileDB-Inc/TileDB.git" />
<description>The TileDB Embedded library. This is a metapackage that will route to the appropriate native package based on the runtime identifier.

To do that you have to make an RID-specific build by setting the RuntimeIdentifier or the UseCurrentRuntimeIdentifier project properties, or by using the -r or -ucr .NET SDK command-line options.</description>
<tags>tiledb</tags>
</metadata>
<files>
Expand Down
2 changes: 1 addition & 1 deletion scripts/nuget/TileDB.Native.runtime.template.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<license type="expression">MIT</license>
<icon>logo.png</icon>
<projectUrl>https://tiledb.com/products/tiledb-embedded/</projectUrl>
<repository type="git" url="https://github.com/TileDB-Inc/TileDB" />
<repository type="git" url="https://github.com/TileDB-Inc/TileDB.git" />
<description>Native binaries of TileDB Embedded for $rid$.</description>
<tags>tiledb</tags>
</metadata>
Expand Down
12 changes: 12 additions & 0 deletions sources/NuGet.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Authors>TileDB Inc</Authors>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageIcon>logo.png</PackageIcon>
<PackageProjectUrl>https://tiledb.com/products/tiledb-embedded/</PackageProjectUrl>
<PackageTags>tiledb</PackageTags>
</PropertyGroup>
<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)/../art/logo.png" Pack="true" PackagePath="" />
</ItemGroup>
</Project>
7 changes: 1 addition & 6 deletions sources/TileDB.CSharp/TileDB.CSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,19 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="../NuGet.props" />
<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Nullable>enable</Nullable>
<RootNamespace>TileDB.CSharp</RootNamespace>
<Version>5.3.0</Version>
<Authors>TileDB Inc</Authors>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageIcon>logo.png</PackageIcon>
<PackageProjectUrl>https://tiledb.com/products/tiledb-embedded/</PackageProjectUrl>
<Description>C# wrapper of the TileDB Embedded universal data engine.</Description>
<PackageTags>tiledb</PackageTags>
</PropertyGroup>

<PropertyGroup>
<OutputPath>./lib</OutputPath>
</PropertyGroup>

<ItemGroup>
<None Include="../../art/logo.png" Pack="true" PackagePath="" />
<PackageReference Include="TileDB.Native" Version="2.12.2" />
</ItemGroup>
</Project>