refactor: change raise NotImplemented to NotImplementedError #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![deepsource-dev-autofix[bot]](https://avatars.githubusercontent.com/u/40287229?s=60&v=4){kind=small}
This PR refactors instances where `NotImplemented` was incorrectly raised, replacing them with the proper `NotImplementedError` exception to adhere to Python conventions and prevent runtime issues. - raising `NotImplemented` is not allowed: The code originally used `raise NotImplemented`, which is invalid because `NotImplemented` is a special singleton return value rather than an exception class. The patch updates each occurrence to `raise NotImplementedError`, ensuring that the correct exception type is thrown and improving overall code reliability. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors instances where
NotImplementedwas incorrectly raised, replacing them with the properNotImplementedErrorexception to adhere to Python conventions and prevent runtime issues.NotImplementedis not allowed: The code originally usedraise NotImplemented, which is invalid becauseNotImplementedis a special singleton return value rather than an exception class. The patch updates each occurrence toraise NotImplementedError, ensuring that the correct exception type is thrown and improving overall code reliability.