Skip to content

Added "SVWebViewControllerDelegate", with done button callback #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added "SVWebViewControllerDelegate", with done button callback #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a9a10d
Grammatical correction on method parameter.
Aug 5, 2016
f2cb848
Implemented SVWebViewControllerDelegate, with callback "didPressDoneB…
Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SVWebViewController/SVModalWebViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ - (void)viewWillAppear:(BOOL)animated {
#pragma mark - Delegate

- (void)setWebViewDelegate:(id<UIWebViewDelegate>)webViewDelegate {
self.webViewController.delegate = webViewDelegate;
self.webViewController.delegate = (id<SVWebViewControllerDelegate>)webViewDelegate;
}

- (id<UIWebViewDelegate>)webViewDelegate {
Expand Down
6 changes: 5 additions & 1 deletion SVWebViewController/SVWebViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@
//
// https://github.com/samvermette/SVWebViewController

@protocol SVWebViewControllerDelegate <UIWebViewDelegate>
-(void) didPressDoneButton;
@end

@interface SVWebViewController : UIViewController

- (instancetype)initWithAddress:(NSString*)urlString;
- (instancetype)initWithURL:(NSURL*)URL;
- (instancetype)initWithURLRequest:(NSURLRequest *)request;

@property (nonatomic, weak) id<UIWebViewDelegate> delegate;
@property (nonatomic, weak) id<SVWebViewControllerDelegate> delegate;

@end
8 changes: 6 additions & 2 deletions SVWebViewController/SVWebViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,12 @@ - (void)actionButtonTapped:(id)sender {
}
}

- (void)doneButtonTapped:(id)sùender {
[self dismissViewControllerAnimated:YES completion:NULL];
- (void)doneButtonTapped:(id)sender {
[self dismissViewControllerAnimated:YES completion:^{
if ([self.delegate respondsToSelector:@selector(didPressDoneButton)]) {
[self.delegate didPressDoneButton];
}
}];
}

@end