Skip to content

A self.self slipped into the code. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

A self.self slipped into the code. #77

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f2834f2
A self.self slipped into the code.
Nov 26, 2013
72126c6
End loading by loading about:blank.
Dec 2, 2013
54fdfbc
Fix activity indicator counts and support delegating the webView and …
Dec 9, 2013
3049bb7
Make a selector constant to defeat a compiler warning about a missing…
adonoho Dec 17, 2013
4a083af
Package up for a trip. Sorry the reasons why each patch is made are b…
adonoho Jun 27, 2014
e9284c4
Add the SVWebViewPresenter protocol.
adonoho Jul 1, 2014
d5fc4ab
Use Google's OpenInChromeController class. This fixed a bug when usin…
adonoho Aug 2, 2014
453f50e
Add the OpenInChromeController submodule.
adonoho Aug 2, 2014
dcbfd71
Properly handle an array of activityItems.
adonoho Aug 23, 2014
aa2e514
Force teh web view to display a blank page. This traditionally reduce…
adonoho Nov 8, 2014
ce0fae2
Move the completion block assignment before the presentation of the p…
adonoho Nov 18, 2014
f849fb9
Restore a super call.
adonoho Dec 12, 2014
99d02ab
Cosmetic edits.
adonoho Dec 12, 2014
e04d795
Update the activities completion handler for iOSv8.
adonoho May 3, 2015
37a3683
Align with iOS naming convention for barTintColor.
adonoho May 12, 2015
eb86389
Use Objective-C @import modules.
adonoho Jun 20, 2015
5cc94d6
Make the Objective-C more robust by explicitly testing for nullability.
adonoho Oct 26, 2015
bb823f7
Update OpenInChrome for iOSv7+.
adonoho Nov 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make a selector constant to defeat a compiler warning about a missing… 
… selector.
  • Loading branch information
@adonoho
adonoho committed Dec 17, 2013
commit 3049bb7b7ee202ecfe293e17829c3ce76d48e2b5
2 changes: 1 addition & 1 deletion SVWebViewController/SVModalWebViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ - (id)initWithURL:(NSURL *)URL {
if (self = [super initWithRootViewController:self.webViewController]) {
UIBarButtonItem *doneButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone
target:self.webViewController
action:@selector(doneButtonClicked:)];
action:kDoneButtonClicked];

if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad)
self.webViewController.navigationItem.leftBarButtonItem = doneButton;
Expand Down
3 changes: 3 additions & 0 deletions SVWebViewController/SVWebViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,7 @@
- (id)initWithAddress:(NSString*)urlString;
- (id)initWithURL:(NSURL*)URL;

#define kDoneButtonClicked (@selector(doneButtonClicked:))
- (void) doneButtonClicked: (id) sender;

@end