feat!: update Nuxt to support version ^3.16.0#164
Conversation
|
We need to add the min nuxt version to the // add this import
import { version } from '../package.json'
// then
meta: {
name: '@tresjs/nuxt',
configKey: 'tres',
compatibility: { // <=== this object
nuxt: '>=3.16.0',
},
version, // <== the version here
}, |
|
I'll check it in a few hours... I guess we need to check a few things about Vue 3.5 and SSR |
|
@userquin For the playground I have this updated package ready. {
"name": "@tresjs/nuxt-playground",
"type": "module",
"private": true,
"scripts": {
"dev": "nuxi dev",
"build": "nuxi build",
"generate": "nuxi generate"
},
"dependencies": {
"@tresjs/cientos": "^4.0.3",
"@tresjs/core": "^4.3.1"
},
"devDependencies": {
"@nuxt/devtools": "2.4.0",
"@types/three": "^0.171.0",
"nuxt": "^3.17.3",
"postprocessing": "^6.36.4",
"tweakpane": "^4.0.5"
}
}
|
|
Looks like the Nuxt UI and UnoCSS dependencies required by the devtools module, I'll check if we need to move them back to the dependencies... |
|
Hi @justserdar thanks for creating a new PR, looks better. Quick thing
|
@alvarosabu That's my normal way (not PRing from main to main), but the contribution guide somehow gave me the impression it said, 'stay on' main branch and fork/PR from that, this conflicted with whats been said on discord, so my bad. I had three simple and small PR's lined up, deleted them. Expect smoother sailing from my PRs. |
@userquin That is good to know, I can move them back too if you haven't yet. |
|
don't change anything, I'm fixing all the dependencies and the devtools module |
|
Here is a public repo using v3.0.8 with updated dependecies that support version ^3.16.0 using a local tgz packed archive. |
It's ok 😉, the guidelines state "Fork the repo and create your branch from main", which means you fork the repo, then you create a branch from it and you use it as origin to merge into Tres:main, take this PR in Nuxt as an example nuxt/nuxt#32189
|
|
Thanks for coming back on this, currently the PR is still not on a separate branch. On discord I mentioned we should close this and get a new PR that is on a diff branch then main. Edit: Discord Link
At that point I was like crap I misinterpreted the contribution guide. Excuse me on that one. I told userquin you wasn't gonna like it and we were better off just creating a clean one. What do you think we should do for here? Close and create a new PR consolidating the progress in proper format. |
|
Hey no worries @justserdar I think we can wait for @userquin to check, because devtools are not working for me atm. Do not add any other changes to your fork main that are outside of the scope of this PR for now. I will block the nuxt module dev until we merge it otherwise your fork will have divergence. After we merge this one, for all other PRs you would like to open, please create branches for them and not use your main anymore 🙏🏻 |



Consolidating the conversation from #161
This PR just has the
package.jsonandlockfilewith updated dependencies for v3.16-3.17 like discussed with @userquin and provided hint.Try it out, let me know.