Skip to content
This repository was archived by the owner on Feb 1, 2026. It is now read-only.

feat!: update Nuxt to support version ^3.16.0#164

Merged
alvarosabu merged 19 commits into
Tresjs:mainfrom
justserdar:main
May 25, 2025
Merged

feat!: update Nuxt to support version ^3.16.0#164
alvarosabu merged 19 commits into
Tresjs:mainfrom
justserdar:main

Conversation

@justserdar

Copy link
Copy Markdown
Contributor

Consolidating the conversation from #161
This PR just has the package.json and lockfile with updated dependencies for v3.16-3.17 like discussed with @userquin and provided hint.

Try it out, let me know.

Comment thread package.json Outdated
Comment thread package.json Outdated
@userquin

userquin commented May 23, 2025

Copy link
Copy Markdown
Member

We need to add the min nuxt version to the module.ts metadata adding also tres nuxt version:

// add this import
import { version } from '../package.json'

// then

  meta: {
    name: '@tresjs/nuxt',
    configKey: 'tres',
    compatibility: { // <=== this object
      nuxt: '>=3.16.0', 
    },
    version, // <== the version here
  },

@userquin

Copy link
Copy Markdown
Member

I'll check it in a few hours... I guess we need to check a few things about Vue 3.5 and SSR

@userquin userquin changed the title feat!: updated dependencies for v3.16-3.17 feat!: update Nuxt to support version ^3.16.0 May 23, 2025
@justserdar

justserdar commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

@userquin For the playground I have this updated package ready.
SSR works in both cases, current and new playground package.

{
  "name": "@tresjs/nuxt-playground",
  "type": "module",
  "private": true,
  "scripts": {
    "dev": "nuxi dev",
    "build": "nuxi build",
    "generate": "nuxi generate"
  },
  "dependencies": {
    "@tresjs/cientos": "^4.0.3",
    "@tresjs/core": "^4.3.1"
  },
  "devDependencies": {
    "@nuxt/devtools": "2.4.0",
    "@types/three": "^0.171.0",
    "nuxt": "^3.17.3",
    "postprocessing": "^6.36.4",
    "tweakpane": "^4.0.5"
  }
}

@userquin

Copy link
Copy Markdown
Member

Looks like the Nuxt UI and UnoCSS dependencies required by the devtools module, I'll check if we need to move them back to the dependencies...

@alvarosabu

alvarosabu commented May 24, 2025

Copy link
Copy Markdown
Member

Hi @justserdar thanks for creating a new PR, looks better. Quick thing

Screenshot 2025-05-24 at 19 06 26

@justserdar

justserdar commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

Hi @justserdar thanks for creating a new PR, looks better. Quick thing

Screenshot 2025-05-24 at 19 06 26

@alvarosabu That's my normal way (not PRing from main to main), but the contribution guide somehow gave me the impression it said, 'stay on' main branch and fork/PR from that, this conflicted with whats been said on discord, so my bad. I had three simple and small PR's lined up, deleted them. Expect smoother sailing from my PRs.

@justserdar

Copy link
Copy Markdown
Contributor Author

Looks like the Nuxt UI and UnoCSS dependencies required by the devtools module, I'll check if we need to move them back to the dependencies...

@userquin That is good to know, I can move them back too if you haven't yet.

@userquin

Copy link
Copy Markdown
Member

don't change anything, I'm fixing all the dependencies and the devtools module

Comment thread client/components/PerformanceMonitor.vue Outdated
Comment thread client/types/index.ts Outdated
@justserdar

justserdar commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

Here is a public repo using v3.0.8 with updated dependecies that support version ^3.16.0 using a local tgz packed archive.

https://github.com/justserdar/tres-ntest-316

@alvarosabu

Copy link
Copy Markdown
Member

@alvarosabu That's my normal way (not PRing from main to main), but the contribution guide somehow gave me the impression it said, 'stay on' main branch and fork/PR from that, this conflicted with whats been said on discord, so my bad. I had three simple and small PR's lined up, deleted them. Expect smoother sailing from my PRs.

It's ok 😉, the guidelines state "Fork the repo and create your branch from main", which means you fork the repo, then you create a branch from it and you use it as origin to merge into Tres:main, take this PR in Nuxt as an example nuxt/nuxt#32189

Screenshot 2025-05-25 at 13 06 24

whats been said on discord
Lol 😂 I was trying to look for the message regarding this, but there was 300 message since last night

@justserdar

justserdar commented May 25, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for coming back on this, currently the PR is still not on a separate branch. On discord I mentioned we should close this and get a new PR that is on a diff branch then main.

Edit: Discord Link
Your message on discord mentioned:

  • create 'feat!'
  • create 'chore'

At that point I was like crap I misinterpreted the contribution guide. Excuse me on that one. I told userquin you wasn't gonna like it and we were better off just creating a clean one.

What do you think we should do for here? Close and create a new PR consolidating the progress in proper format.
Or what do you think?

@alvarosabu

Copy link
Copy Markdown
Member

Hey no worries @justserdar I think we can wait for @userquin to check, because devtools are not working for me atm. Do not add any other changes to your fork main that are outside of the scope of this PR for now. I will block the nuxt module dev until we merge it otherwise your fork will have divergence.

After we merge this one, for all other PRs you would like to open, please create branches for them and not use your main anymore 🙏🏻

@alvarosabu alvarosabu merged commit 7858a68 into Tresjs:main May 25, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants