Skip to content

[codex] Fix Firefox message reply overflow and other compose area issues#2744

Draft
guaka wants to merge 7 commits into
mainfrom
codex/fix-firefox-message-reply-overflow
Draft

[codex] Fix Firefox message reply overflow and other compose area issues#2744
guaka wants to merge 7 commits into
mainfrom
codex/fix-firefox-message-reply-overflow

Conversation

@guaka

@guaka guaka commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Bounds the message thread flex layout so Firefox can shrink the message list instead of pushing the reply composer below the viewport.
  • Keeps the reply editor internally scrollable after a capped height while leaving the send controls visible.
  • Adds a targeted Firefox Playwright project and regression test for the long-reply overflow case.
  • Updates the e2e browser setup so Firefox is available in CI alongside Chromium.

Fixes #2722

Validation

  • npm run test:client -- ThreadReply
  • bash -n scripts/e2e/test-e2e.sh
  • npx eslint modules/messages/client/components/Thread.component.js modules/messages/client/components/ThreadMessages.js modules/messages/client/components/ThreadReply.js playwright.config.js tests/e2e/test.js tests/e2e/messages-layout.spec.js
  • TRUSTROOTS_E2E_SKIP_COVERAGE_REPORT=true npm run test:e2e -- --project=messages --project=messages-firefox-layout --grep "reply editor remains usable"

Notes

  • The full e2e suite was also attempted. The new messages-firefox-layout test and the existing messages project passed, but the full run ended with unrelated public/auth/member failures and later ENOSPC: no space left on device errors after generating large Playwright artifacts locally.

@guaka guaka added the run-e2e label Jun 13, 2026
@guaka guaka marked this pull request as ready for review June 20, 2026 18:15
@guaka guaka added the screenshots for PRs: try to automatically add some sensible screenshots as comments label Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

E2E screenshots

Run: https://github.com/Trustroots/trustroots/actions/runs/29268773056

messages-firefox-layout-reply editor remains usable when long text overflows

messages-firefox-layout-reply editor remains usable when long text overflows

setup-authenticated-create admin storage state

setup-authenticated-create admin storage state

setup-authenticated-create authenticated storage state

setup-authenticated-create authenticated storage state

setup-authenticated-create seeded member storage state

setup-authenticated-create seeded member storage state

github-actions Bot added a commit that referenced this pull request Jun 20, 2026
@guaka guaka removed the run-e2e label Jul 3, 2026
github-actions Bot added a commit that referenced this pull request Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

trustroots@0.3.3 coverage:pr-summary
node ./scripts/coverage/generate-pr-summary.js

Coverage overview

Status: Passing

Suite Status Recorded Result Report
Client2026-07-05 18:25
Duration 3m 01s
Statements  🟢 100.00%
Branches    🟢 100.00%
Functions   🟢 100.00%
Lines       🟢 100.00%
coverage-client
Server2026-07-05 18:24
Duration 1m 34s
Statements  🟢 100.00%
Branches    🟢 100.00%
Functions   🟢 100.00%
Lines       🟢 100.00%
coverage-server
End-to-end2026-07-05 18:27
Duration 5m 22s
Tests              🟢 157/157
Pass rate          🟢 100.00%
Areas              🟢 8/8
Features           🟢 97/97
Scenarios          🟢 236/236
Feature coverage   🟢 100.00%
Scenario coverage  🟢 100.00%
playwright-report

End-to-end areas

Area Status Passed Failed Total
Admin 20 0 20
Authentication 17 0 17
Experiences 8 0 8
Member flows 53 0 53
Messages 14 0 14
Nostr 8 0 8
Public pages 32 0 32
Seeded content 5 0 5
Total 157 0 157

Full HTML overview: download the coverage-report artifact from this workflow run.

github-actions Bot added a commit that referenced this pull request Jul 13, 2026
@guaka

guaka commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

we might as well want to fix other stuff related to the compose area

  • when going back with the cursor when there are multiple lines, weird stuff happens
  • this came in through support: "In the edit box for reply to messages (differently from the one where i write now) it is not possible to use dead keys, and compose key, that lead to be impossible to write certain words in certain languages."

@guaka guaka changed the title [codex] Fix Firefox message reply overflow [codex] Fix Firefox message reply overflow and other compose area issues Jul 13, 2026
@guaka guaka marked this pull request as draft July 13, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helpful for support screenshots for PRs: try to automatically add some sensible screenshots as comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

text drops of bottom of screen

1 participant