sound: Rebrand as URL Playback to avoid confusion with the built-in sound category#2121
Merged
CubesterYT merged 6 commits intoTurboWarp:masterfrom May 21, 2025
Merged
Conversation
github-actions
bot
added
the
pr: change existing extension
Contributor
Author
|
If you want me to change something, feel free too :) |
Member
|
good idea |
GarboMuffin
changed the title
GarboMuffin
approved these changes
May 21, 2025
CubesterYT
approved these changes
May 21, 2025
Contributor
|
As a musician, it's really going to bother me that the note heads are centered with the stems instead of adjacent to the stems in the new banner. Eighth notes are supposed to look like this: |
Member
|
Can you fix it? |
Contributor
I'll probably open a PR sooner or later, there's probably other music familiar people that are bothered by it |
Contributor
Author
|
@GarboMuffin was I supposed to update the image attribution or will you do that |
Member
|
It would happen more quickly if you can submit a pull request |
Contributor
Author
Alright I'll do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes revamped menu icon and banner (both made in Figma, inspired by @WAYLIVES's designs, font is Lohit Devanagari)
I also changed the color scheme of the extension. The existing code was pretty bare-bones so adding an icon and a color wasn't too hard.
Other than rebrands, the extension's code is unchanged. The blocks still function the way they used to and the ID remains the same.