You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(gl): doctor agreeing-path should match transport security and node identity gates #601
Follow-up from PR #394 / CodeRabbit review — not a regression in that PR. The new divergence probe (probe_transport) already matches the git helper for redirects, DID identity, proxy/no_proxy, and plaintext-remote refusal. The agreeing path (when resolve_transport_node equals args.node.trim()) still behaves like pre-main doctor.
Problems (pre-existing on merge-base)
Plaintext remote GITLAWB_NODE without --node
Check 3 runs only gitlawb_node_env_check and can Pass for a non-loopback http:// URL. git-remote-gitlawb still refuses via check_transport_security before any request. Doctor does not surface the same refusal on this path.
HTTP 200 that is not a gitlawb node (env-only config)
When URLs agree, check 3 does not run the DID probe. Check 4 (node row) still Passes on success with resp.json() and shows did as ? when JSON lacks a valid DID (crates/gl/src/doctor.rs connectivity block). A random service returning HTML/empty JSON can look healthy.
Suggested scope (maintainer choice)
On the agreeing path, apply the same transport-policy refusal as probe_transport (or call a shared helper) before marking GITLAWB_NODE Pass.
Require a parseable DID (or equivalent identity) for the node connectivity check, or route agreeing installs through the same identity probe as the divergence row.
Add regression tests: env-only GITLAWB_NODE pointing at HTML 200; env-only plaintext remote without GITLAWB_ALLOW_INSECURE_HTTP.
Activity