Repository navigation
fix(git-remote): drive multi-round fetch as a v0 stateless-RPC client loop (#117) #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a64b141
fix(git-remote): drive multi-round fetch as a v0 stateless-RPC client…
beardthelion 89c0ad5
test(git-remote): real-git integration proof of the multi-round fetch…
beardthelion 68ba492
fix(git-remote): skip content-free flush rounds in the fetch loop (#117)
beardthelion c4609d4
test(git-remote): close branch-coverage gaps in the fetch loop (#117)
beardthelion 1cb930c
fix(git-remote): abort fetch on EOF without POSTing; harden the real-…
beardthelion 4201ce4
test(git-remote): reap the whole fetch process group and make the wit…
beardthelion 22ec66a
test(git-remote): make the run_bounded harness portable to the shippe…
beardthelion 1c690c1
fix(node): count a completed fetch once per fetch, not per stateless-…
beardthelion bf4d8cd
test(git-remote): bound the fetch reader joins when the leader exits …
beardthelion 8c04043
fix(git-remote): reject malformed pkt-line length headers instead of …
beardthelion c45ec96
fix(node): make metrics::init race-safe with Once
beardthelion 5a5d4e1
fix(node): count fetch completion from the response outcome, not the …
beardthelion 63cb52b
test(git-remote): bind the withheld-path test to the expected ACK/NAK…
beardthelion 659ee00
test(git-remote): tear down the fetch tree with a Job Object on Windo…
beardthelion 01971f7
test(git-remote): make the Windows Job Object mandatory in run_bounded
beardthelion a53c151
chore: sync Cargo.lock after rebase onto main
beardthelion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(git-remote): abort fetch on EOF without POSTing; harden the real-…
…git test harness (#192) F1: a nonempty have-batch terminated by EOF means git aborted mid-negotiation, but the fetch loop folded RoundEnd::Eof into the Done arm, appended a synthetic 0009done, and POSTed it — so a cancelled private fetch still issued an authorized, signed upload-pack request and made the node generate and stream a full pack to a client that had gone away. Split the arm: only a real done pkt finalizes; a nonempty EOF terminates without a POST. The nonempty_eof_batch_posts_as_final_round test that locked in the wrong behavior is flipped to assert no POST. F2: fetch_with_helper piped stdout+stderr but only polled try_wait, so a fetch emitting more than an OS pipe buffer (~64 KiB) blocked git before it exited and the harness reported a false 30s deadlock. Drain both streams on reader threads while enforcing the deadline, so the deadline measures a real protocol hang only. F3: the integration repos were removed only on the success path (predictable pid/counter names), so a timeout/panic leaked real git repos and could poison a later run. Root them in a RAII tempfile::TempDir that drops on unwind. RED->GREEN: nonempty_eof_batch_aborts_without_posting (pre-fix POSTs a synthetic done → the aborted-negotiation POST fails against the single-response server; fixed makes one request, no POST). repos_are_cleaned_up_on_unwind (temp dir gone after a panic unwinds past the guard). Full git-remote-gitlawb suite 42 unit + 3 integration green, fmt + clippy clean.
- Loading branch information
commit 1cb930cbd57ea5d232edddc8e50dc94fab4362a5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,4 @@ tracing-subscriber = { workspace = true } | |
|
|
||
| [dev-dependencies] | ||
| mockito = "1" | ||
| tempfile = "3" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.