Repository navigation
fix(icaptcha-client): parse GITLAWB_ICAPTCHA_INSECURE as truthy only (#227) #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Ayush7614
wants to merge
7
commits into
Twigpine:main
from
Ayush7614:fix/227-icaptcha-insecure-parse
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3346b0f
fix(icaptcha-client): parse GITLAWB_ICAPTCHA_INSECURE as truthy only
Ayush7614 7d218ac
fix(icaptcha-client): address #246 review (trim test, fmt, lock)
Ayush7614 8e20002
fix(icaptcha-client): do not log raw ICAPTCHA_INSECURE value
Ayush7614 16eaa3e
fix(icaptcha-client): pure insecure flag helpers for #246 review
Ayush7614 45f3de1
fix(icaptcha-client): cover real env read + fix warn spacing
Ayush7614 28e4d02
Merge remote-tracking branch 'origin/main' into HEAD
kevincodex1 ce2fff8
fix(icaptcha-client): put the non-truthy warning on one literal line
kevincodex1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.