Repository navigation
fix(node): fence a repo publish on the write attempt that owns it #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12,049
−1,662
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
7af3067
fix(node): close the advisory-lock probe's session if it is dropped m…
beardthelion edcf0f2
fix(node): add a dedicated, lazily-connected advisory-lock pool
beardthelion 5ce3c7f
fix(node): hold the lock-owning connection in RepoWriteGuard (#279)
beardthelion c49d3cd
fix(node): free the advisory lock when a write guard dies without rel…
beardthelion 98f2daf
fix(node): read the advisory unlock's result instead of discarding it
beardthelion 9321d3b
fix(node): bound the object-storage transfers that run under the writ…
beardthelion 9da0939
fix(node): authorize before taking the write lock in close_issue
beardthelion 5d254fb
fix(node): address the review findings on the advisory-lock series
beardthelion d346bde
fix(node): log lock-pool saturation in the request path, not via read…
beardthelion 82143ad
fix(node): refuse a write when object storage is unknowable, and shed…
beardthelion 8cf6b7a
fix(node): re-authorize close_issue under the guard instead of only r…
beardthelion af5948b
style(node): rustfmt the new contention test
beardthelion e5558fb
fix(node): shed an unrefreshable write as a retryable 503 with a fixe…
beardthelion 63a9ef8
fix(node): refuse a fresh-copy write when the archive HEAD cannot be …
beardthelion 10230ac
fix(node): log expected transient acquire failures at warn, not error
beardthelion 259d587
fix(node): log the read failure the close_issue pre-check folds into …
beardthelion 999ee72
test(node): poll for the closed session instead of sleeping a fixed 3…
beardthelion 5fdb902
fix(node): raise a failed fresh download with no local copy as RepoUn…
beardthelion f81ebbe
test(node): assert the second writer sheds as RepoBusy instead of tim…
beardthelion c4dbd8a
fix(node): read the close_issue author pre-check from a non-mutating …
beardthelion 9f313b9
fix(node): bound every await in the lock-acquire loop by the deadline
beardthelion 60d70c7
test(node): add an S3 mock that really enforces conditional writes
beardthelion 31f90c4
fix(node): stop pretending a held lock fences a late upload
beardthelion 3eabf79
feat(node): let the storage client express and detect a conditional w…
beardthelion 317841e
fix(node): fence the release publish so an abandoned upload cannot win
beardthelion 3d803ff
test(node): drive the abandoned-upload race end to end, and probe the…
beardthelion 2a92a1f
fix(node): reconcile F-series tests and test seams with the rebased g…
beardthelion 9f35dca
fix(node): address the 2026-08-10 review round on the advisory-lock s…
beardthelion 9dd71e9
fix(node): record why the close-issue read gate cannot carry a synced…
beardthelion 4cee7e0
merge origin/main into fix/279-advisory-lock-session-affinity
beardthelion b35cb31
fix(node): address jatmn review on merged advisory-lock head
beardthelion 3c20148
fix(node): cap close_issue snapshot work on the read pool
beardthelion 7ba0fef
fix(node): mark close_issue mirror visibility gate for push hook
beardthelion 3df71c9
fix: unblock pre-push after main merge
beardthelion 98fe670
fix(node): carry transient acquire failures through every write handler
beardthelion 4f1c1bb
fix(node): drop unused logcap helper after drain_faults seam
beardthelion 4eb0c44
fix(node): route fork disk paths through validated_repo_disk_path
beardthelion d1ce2e3
fix(node): harden release-upload outcomes and replication tail gating
beardthelion 8e66e77
fix(node): close jatmn round on publish authority and durability gating
beardthelion 1911291
fix(node): harden issue close/create and fork publish paths on #285
beardthelion 5d3a4ea
fix(node): close write-attempt ownership gaps on advisory-lock release
beardthelion 2ad2f12
fix(node): gate replication tail on publish durability and split clos…
beardthelion 487687c
fix(node): add ValidatedRepoDiskPath for CodeQL and reconcile tail du…
beardthelion 9d02139
fix(node): close three jatmn findings on advisory-lock PR
beardthelion 85c6f48
fix(node): verify adversarial findings on advisory-lock PR
beardthelion 5cd6703
fix(node): compensate under the write lock and harden tail durability…
beardthelion 22da2d6
fix(node): refuse stale under-lock refresh and gate tail durability o…
beardthelion c306933
style(node): rustfmt advisory-lock gap-closure commits
beardthelion 3a82ccb
fix(node): satisfy clippy on stale-local download test path join
beardthelion c40f299
feat(node): add a publish attempt/stage boundary
kevincodex1 21646bc
feat(node): stamp uploads with an attempt id and preserve dispatch am…
kevincodex1 5e548d2
fix(node): key durability, cache validity and fork cleanup on the att…
kevincodex1 535c5dc
fix(node): settle the cache contract on the abandoned path and the at…
beardthelion f048a1e
fix(node): settle the abandoned tree at the disconnect, not at reaper…
beardthelion 957d50b
fix(node): let exactly one classifier settle an abandoned tree
beardthelion 892c752
Merge origin/main into fix/279-advisory-lock-session-affinity
beardthelion 28f3fc2
test(node): use the test's own pool now that Db::pool is gone
beardthelion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(node): shed an unrefreshable write as a retryable 503 with a fixe…
…d body The two refusal arms added for the under-lock transfer bound returned bare anyhow errors, so AppError's From impl (which downcasts only sqlx::Error and RepoBusy) landed them in Internal: a 500 internal_error whose body was the error string. Two defects in one. A transient object-storage failure told the client not to retry, and the timeout arm's message interpolated the owner slug and repo name straight into the response body, contradicting the fixed-body policy the RepoBusy arm sets six lines above it. RepoUnavailable follows RepoBusy exactly: a fieldless type raised with the operator detail in a context string, downcast to its own rung, mapped to a 503 whose body interpolates nothing. The detail stays in the log at the raise site. The timeout arm logs at error! where its sibling logs at warn!, deliberately: a 300s stall pinned a lock-pool slot for five minutes and is the condition the transfer bound exists to surface, so it must keep paging when the handler classifier demotes the ordinary blip case.
- Loading branch information
commit e5558fbb2784ba4a5bd890eb46d88c619f14420d
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.