Repository navigation
fix(node): bind a peer row to its DID so only its keyholder can repoint it (#273) #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
14481df
fix(node): bind a peer row to its DID at the upsert_peer boundary (#273)
beardthelion 7cdfb84
test(node): bind the peer-authority gate and ledger its writers (#273)
beardthelion 73bf132
fix(node): resolve the key on the unproven insert path, and bound the…
beardthelion b6ebaa4
fix(gl): surface the node's refusal instead of reporting a peer add t…
beardthelion ebb93e3
test(gl): pin the local-add refusal warning to the node's production …
beardthelion df2a179
fix(node): report an unresolvable did:key distinctly from an unsuppor…
beardthelion e8f091e
fix(node): give the unresolvable-DID refusal its own error code
beardthelion 8b3aa1d
fix(gl): defang and bound node-supplied text before it reaches the te…
beardthelion 895fcf0
fix(gl): check the peer's status before parsing its announce reply
beardthelion d6434b2
fix(node): scope the unproven DID check to the insert, not to the DID
beardthelion 8313c10
test(node): make the peers-write scan see a statement split across lines
beardthelion 5df7d2a
test(gl): pin the local-add print selection, not just its helper
beardthelion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(gl): defang and bound node-supplied text before it reaches the te…
…rminal The peer-add refusal warning added earlier in this branch copied the node's message straight into stderr, and both announce bodies were read unbounded, so a hostile --node endpoint, a compromised local node, or a MITM on plain http could put ANSI or OSC escapes into the user's terminal. The accepted-announce block had the same hole on the success path, where the DID and URL come from a peer whose URL the caller chose. sanitize_node_msg and read_body_capped move from sync.rs to http.rs, which already owns the wire boundary, and both paths in peer.rs now use them. Only the display is sanitized: the values forwarded to the local node stay verbatim, since that is data rather than terminal output.
- Loading branch information
commit 8b3aa1decf7b6e4a95ae1dc756d296cd47fcc194
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.