Repository navigation
feat(node)!: anchor the UCAN proof chain and honour delegated git/push #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+5,537
−259
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2a8d64d
feat(core)!: verify_chain returns the proof chain's root issuer
Vasanthdev2004 13a2424
fix(node): gate two Unix-only tests so the crate compiles on Windows
Vasanthdev2004 1b1c972
feat(node): carry the verified UCAN and its root into the request
Vasanthdev2004 f8b9cf1
feat(node): add ucan_grants_push, anchored at the repo owner
Vasanthdev2004 d27f0be
feat(node): honour a delegated git/push capability on the push path
Vasanthdev2004 d141e59
feat(gl): gl ucan import stores a delegation for the push helper
Vasanthdev2004 3d81f57
feat(git-remote): send a delegated push capability as X-Ucan
Vasanthdev2004 8843c4f
test(git-remote): cover pack-POST URL splitting
Vasanthdev2004 a9e9c48
build: sync Cargo.lock for the git-remote-gitlawb dependencies
Vasanthdev2004 f455726
fix(core,gl,git-remote): close two review findings on delegated push
Vasanthdev2004 a2502fc
fix(core,node,gl,git-remote): close the second review round on delega…
Vasanthdev2004 d503655
fix(gl): restrict the delegations directory, and state the contract
Vasanthdev2004 5071524
fix(gl,git-remote): make a delegation issued the documented way actua…
Vasanthdev2004 5dfd8c5
fix(gl): refuse a relative or non-UTF-8 GITLAWB_KEY when deriving the…
Vasanthdev2004 e15fa73
fix(identity): one resolver for GITLAWB_KEY across gl and the helper
Vasanthdev2004 05fc52d
test(git-remote): cover delegation_header end to end
Vasanthdev2004 75aa1a0
fix(gl): finish the identity-path sweep on the write side
Vasanthdev2004 fad75a6
fix(gl,core): close round five — lazy home, envelope reads, honest re…
Vasanthdev2004 82f2484
fix(node,gl,git-remote): enforce repo narrowing at the node, honour t…
Vasanthdev2004 a47ea93
fix(gl): align the MCP ucan_show tool with gl ucan show
Vasanthdev2004 ec4399c
fix(gl): drop a needless borrow in quickstart's unix key write
Vasanthdev2004 1ab55e5
fix(node,gl,git-remote): fix a delegation's scope at issuance
Vasanthdev2004 89fa647
Merge origin/main into feat/ucan-push-authorization
Vasanthdev2004 9cf48f5
fix(gl): drop an unused import in the unix-only refresh tests
Vasanthdev2004 04e7941
fix(node): pass the UCAN extension at the last two receive-pack call …
Vasanthdev2004 f79309b
fix(core,node,gl,git-remote): one definition of a usable push capability
Vasanthdev2004 4dc62b2
fix(node): drop repo_capability_matches, orphaned by the shared push …
Vasanthdev2004 1da4251
fix(core,gl): bound every proof-chain walk and make verify report the…
Vasanthdev2004 fb831b1
docs: state the two gates a delegated push crosses, and finish the sweep
Vasanthdev2004 8b91f28
fix(gl): store one repository per imported delegation; pin the two-ga…
Vasanthdev2004 e3314c6
fix(gl,core): sanitize token-derived output, prove the publish step, …
Vasanthdev2004 1b5cb7d
test(gl): count the MCP tool list at 41 with ucan_import
Vasanthdev2004 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat(core)!: verify_chain returns the proof chain's root issuer
verify_chain returned Result<()>, so a caller learned that a chain was internally consistent and nothing else. `did:key` is self-certifying: anyone can mint a keypair, self-issue `*` on `*`, and produce a token that verifies. That is correct UCAN behaviour rather than a defect — a token with no proofs is its own root — and it still verifies after this change. But it does mean "the chain verifies" is not an authorization answer on its own, and without the root identity no caller could ask the question that actually decides a push: does this chain rest on someone this repository trusts? Returning the root means a caller cannot accept a chain without being handed the identity it rests on. Callers that legitimately do not care — the node middleware checking that a bootstrap token is well-formed, for one — discard it explicitly. The doc comment now states outright that this establishes internal consistency and not trust, and names what a caller has to compare the root against. Multi-proof chains are refused: more than one proof means more than one root, and nothing says which root authorized a given capability, so returning any single one would be unsound. The old loop followed every proof but returned nothing, so a two-proof chain verified silently; the new test pinned that by observing the pre-fix code accept one. Ucan::delegate only ever writes one proof, so no token this codebase produces is affected. BREAKING CHANGE: Ucan::verify_chain returns Result<Did> instead of Result<()>.
- Loading branch information
commit 2a8d64d05748212a29b73be2bae3e6c8d04b89bd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.