Repository navigation
fix(gl): derive View: URL from node instead of hardcoding gitlawb.com (#370) #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+705
−21
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4fc7ad3
fix(gl): derive View: URL from node instead of hardcoding gitlawb.com…
Gravirei 9ca4fcf
fix(gl): validate web_url response and trim trailing slashes (#370)
Gravirei 195a017
fix: address review feedback on View-URL PR (#370)
Gravirei 40350d8
fix: validate web_url format and surface node info failures (#370)
Gravirei 57276ca
fix: reject query/fragment web_urls and warn on node info errors (#370)
Gravirei 98d3795
fix(gl): cap node info body and reject control-byte web_urls (#370)
Gravirei 6c40812
chore: bump h2 to 0.4.19 for RUSTSEC-2026-0258
Gravirei a6113fd
Merge branch 'main' into fix/issue-370-view-url-404
Gravirei 4c48511
fix(gl): close merge regressions on #370 branch and pin View: with in…
Gravirei 10da6f6
fix(gl,node): normalize stored web_url and reject userinfo (#370 review)
Gravirei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: address review feedback on View-URL PR (#370)
- Extract fetch_node_web_url() helper for testability; add 6 unit tests covering: web_url present, trailing-slash trim, absent, empty string, whitespace-only, and server error - Reject empty/whitespace-only GITLAWB_WEB_URL at boot in Config::validate() - Trim whitespace from web_url in the CLI helper (not just trailing slashes) - Document GITLAWB_WEB_URL in .env.example alongside GITLAWB_PUBLIC_URL - Mirror uses shared fetch_node_web_url() helper
- Loading branch information
commit 195a0179b8da8b561dfe7c5475746704717f5bce
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.