Repository navigation
feat(node): enforce per-route authorization across the REST and GraphQL surface #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5168665
test(node): add HTTP-API integration harness with CI Postgres
beardthelion 6404165
feat(node): enforce per-route authorization on REST mutations
beardthelion 531e5db
feat(node): authenticate GraphQL mutations
beardthelion c9dab38
fix(node): path-scope the get_tree visibility gate
beardthelion 6e8cbb6
fix(node): authorize task completion and read-gate PR/issue creation
beardthelion 0b18a21
test(node): harden the authz drift-guard against false passes
beardthelion 8e87100
fix(node): P3 consistency batch from the adversarial review
beardthelion 5c5c92b
fix(node): unify protect/visibility owner checks on did_matches
beardthelion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(node): harden the authz drift-guard against false passes
The guard asserted a marker STRING appeared in each handler body, which a bare identifier in a comment or log line could satisfy even after the real gate was deleted, and its body slice over-ran on any handler not declared exactly 'pub async fn'. - Markers are now gate-shaped: a call (require_repo_owner(, did_matches(, authorize_repo_read() or a binding/comparison expression (caller != &record.owner_did, let owner_did = auth.0), never a field name. - Full-line comments are stripped before matching, so a gate that survives only as a comment no longer counts as enforced. - The body slice bounds at the next top-level fn item across pub async, pub(crate) async, async, pub, and bare fn forms. - Adds rows for the now-read-gated create_pr/create_issue and for fork_repo, create_repo, set_profile, claim_bounty; register is excluded with a note (it trusts the body did, tracked as P3 D3-1). - Adds a self-test proving a comment-only marker does not satisfy a row.
- Loading branch information
commit 0b18a21d70110104458f9dae066f4abd63e55d48
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.