Skip to content

buildSolutionReferences with instance transformers #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

buildSolutionReferences with instance transformers #1274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
22c7a7b
buildSolutionReferences with instance transformers
Mar 27, 2021
8967f6f
fix build
Mar 28, 2021
9b65d9e
fix prettier problems
Mar 28, 2021
da71437
handle all kinds of invalidatedProject
Mar 28, 2021
2f8bb31
let invalidatedProject 'done' function do the job
Mar 28, 2021
15483aa
Merge branch 'master' into bugfix/use-transformers-with-project-refer…
gasnier Mar 28, 2021
bdd8cc9
code simplification
Mar 28, 2021
9c5cc49
override program.emit to always pass transformers
Mar 29, 2021
d3fdbdb
Merge branch 'main' into bugfix/use-transformers-with-project-references
gasnier Mar 29, 2021
55c03a2
Merge branch 'TypeStrong_main' into bugfix/use-transformers-with-proj…
Apr 18, 2021
6f3f203
handle transformers in a single place
Apr 19, 2021
010d859
revert move buildSolutionReferences
Apr 19, 2021
6bb61d4
Merge branch 'main' into bugfix/use-transformers-with-project-references
johnnyreilly Apr 26, 2021
093ef04
cleanup code
May 5, 2021
67d18a3
Merge branch 'main' into bugfix/use-transformers-with-project-references
gasnier May 5, 2021
e8b2bc8
Explicitly check for undefined
johnnyreilly May 6, 2021
2f951fc
Explicitly check for true
johnnyreilly May 6, 2021
8804f19
Merge branch 'main' into bugfix/use-transformers-with-project-references
johnnyreilly May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code simplification
  • Loading branch information
gasnier committed Mar 28, 2021
commit bdd8cc927994bfd207c1bc7be0ff28ca46fe7fc7
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import * as webpack from 'webpack';

import * as constants from './constants';
import {
buildSolutionReferences,
getEmitOutput,
getInputFileNameFromOutput,
getTypeScriptInstance,
Expand Down Expand Up @@ -52,6 +53,7 @@ function successLoader(
instance: TSInstance
) {
initializeInstance(loaderContext, instance);
buildSolutionReferences(instance, loaderContext); //build references after setting transformers and hooks
reportTranspileErrors(instance, loaderContext);
const rawFilePath = path.normalize(loaderContext.resourcePath);

Expand Down
3 changes: 1 addition & 2 deletions src/instances.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ export function initializeInstance(
: instance.compiler.createProgram([], instance.compilerOptions));

instance.transformers = getCustomTransformers(program);
buildSolutionReferences(instance, loader); //build references after setting transformers
// Setup watch run for solution building
if (instance.solutionBuilderHost) {
addAssetHooks(loader, instance);
Expand Down Expand Up @@ -455,7 +454,7 @@ export function initializeInstance(
instance.languageService!.getProgram()
);
}
buildSolutionReferences(instance, loader); //build references after setting transformers

addAssetHooks(loader, instance);

loader._compiler.hooks.watchRun.tapAsync(
Expand Down