Skip to content

Use custom transformer when building solution references #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Use custom transformer when building solution references #1550

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3720126
Refactor getting custom transformer into a dedicated function
feosuna1 Nov 21, 2022
ece3ea2
Implement `getCustomTransformer` in `makeSolutionBuilderHost`
feosuna1 Nov 21, 2022
cc36048
Merge branch 'main' into feo/bugfix/custom-transformer-in-build-solution
johnnyreilly Nov 25, 2022
7c20481
Remove redundant `.toString`
feosuna1 Nov 25, 2022
ed3f70f
Runtime check that project is a string
feosuna1 Nov 26, 2022
0ca0902
Update `CHANGELOG.md` and `package.json`
feosuna1 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant .toString 
`options.configFilePath` is always a string, there's no reason we need `toString()` too.
  • Loading branch information
@feosuna1
feosuna1 authored Nov 25, 2022
commit 7c2048177939840e56624e6abe967c1af9a4386b
2 changes: 1 addition & 1 deletion src/servicesHost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ export function makeSolutionBuilderHost(
if (options) {
// The `configFilePath` is the same value that is used as the `project` parameter of
// `getCustomtransformers` below.
const project = options.configFilePath?.toString();
const project = options.configFilePath;
if (project) {
// Custom transformers need a reference to the `typescript.Program`, that reference is
// unavailable during the the `getCustomTransformers` callback below.
Expand Down