cleanup node internalBinding stuff

dist-raw/node-internal-modules-cjs-loader.js

@@ -21,7 +21,7 @@ const { pathToFileURL, fileURLToPath } = require('url');
 const fs = require('fs');
 const path = require('path');
 const { sep } = path;
-const { internalModuleStat } = require('./node-internal-fs');
+const { internalModuleStat } = require('./node-internalBinding-fs');
 const packageJsonReader = require('./node-internal-modules-package_json_reader');
 const {
   cjsConditions,
@@ -129,7 +129,6 @@ function readPackageScope(checkPath) {
  * }} opts
  */
 function createCjsLoader(opts) {
-  // TODO don't need this if we get it from Object.keys(module.extensions) always?
   const {nodeEsmResolver, compiledExtensions, preferTsExts} = opts;
 const {
   encodedSepRegEx,

dist-raw/node-internal-modules-package_json_reader.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const { SafeMap } = require('./node-primordials');
-const { internalModuleReadJSON } = require('./node-internal-fs');
+const { internalModuleReadJSON } = require('./node-internalBinding-fs');
 const { pathToFileURL } = require('url');
 const { toNamespacedPath } = require('path');
 // const { getOptionValue } = require('./node-options');

dist-raw/node-internalBinding-fs.js

@@ -1,5 +1,43 @@
-// TODO unify this with node-internal-fs?
+const fs = require('fs');
 
-exports.internalModuleStat = function(path) {
+// In node's core, this is implemented in C
+// https://github.com/nodejs/node/blob/v15.3.0/src/node_file.cc#L891-L985
+/**
+ * @param {string} path
+ * @returns {[] | [string, boolean]}
+ */
+function internalModuleReadJSON(path) {
+  let string
+  try {
+    string = fs.readFileSync(path, 'utf8')
+  } catch (e) {
+    if (e.code === 'ENOENT') return []
+    throw e
+  }
+  // Node's implementation checks for the presence of relevant keys: main, name, type, exports, imports
+  // Node does this for performance to skip unnecessary parsing.
+  // This would slow us down and, based on our usage, we can skip it.
+  const containsKeys = true
+  return [string, containsKeys]
+}
 
+// In node's core, this is implemented in C
+// https://github.com/nodejs/node/blob/63e7dc1e5c71b70c80ed9eda230991edb00811e2/src/node_file.cc#L987-L1005
+/**
+ * @param {string} path
+ * @returns {number} 0 = file, 1 = dir, negative = error
+ */
+function internalModuleStat(path) {
+  try {
+    const stat = fs.statSync(path);
+    if(stat.isFile()) return 0;
+    if(stat.isDirectory()) return 1;
+  } catch(e) {
+    return -e.errno || -1;
+  }
 }
+
+module.exports = {
+  internalModuleReadJSON,
+  internalModuleStat
+};