Skip to content

Drop support for traits within annotation title/message format #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 2 commits into from
Nov 23, 2025
Merged

Drop support for traits within annotation title/message format #55

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d60f468
Discard duplicate traits
Tyrrrz Nov 23, 2025
17598b6
Remove support for traits
Tyrrrz Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Discard duplicate traits
  • Loading branch information
@Tyrrrz
Tyrrrz committed Nov 23, 2025
commit d60f468cd8c89a25bd7d3992e258d6009b594d45
3 changes: 2 additions & 1 deletion GitHubActionsTestLogger/MtpLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ CancellationToken cancellationToken
message.TestNode.TryGetSourceLine(),
message
.TestNode.Properties.OfType<TestMetadataProperty>()
.ToDictionary(p => p.Key, p => p.Value)
.DistinctBy(p => p.Key, StringComparer.Ordinal)
.ToDictionary(p => p.Key, p => p.Value, StringComparer.Ordinal)
);

var testResult = new TestResult(
Expand Down
3 changes: 2 additions & 1 deletion GitHubActionsTestLogger/VsTestLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ private void OnTestResult(TestResultEventArgs args)
args.Result.TryGetSourceFilePath(),
args.Result.TryGetSourceLine(),
args.Result.Traits.Union(args.Result.TestCase.Traits)
.ToDictionary(t => t.Name, t => t.Value)
.DistinctBy(t => t.Name, StringComparer.Ordinal)
.ToDictionary(t => t.Name, t => t.Value, StringComparer.Ordinal)
);

var testResult = new TestResult(
Expand Down
Loading