-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add polyfill for Environment.ProcessId
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a polyfill for Environment.ProcessId, which provides access to the current process ID for .NET versions prior to .NET 5.0. This allows developers targeting older frameworks to use the modern Environment.ProcessId API.
- Implements
Environment.ProcessIdpolyfill for pre-.NET 5.0 frameworks - Adds comprehensive test coverage for the new polyfill in the Net50 test suite
- Follows the existing polyfill pattern used in the codebase (e.g., similar to
Environment.ProcessPathin Net60)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PolyShim/Net50/Environment.cs | Adds ProcessId property that returns the current process ID using Process.GetCurrentProcess().Id |
| PolyShim.Tests/Net50/EnvironmentTests.cs | Adds unit test to verify ProcessId returns the correct value |
| PolyShim.Tests/Net60/EnvironmentTests.cs | Adds unit test for ProcessPath (appears to be related cleanup/organization) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.