Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 15, 2025 13:57
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a polyfill for Environment.ProcessId, which provides access to the current process ID for .NET versions prior to .NET 5.0. This allows developers targeting older frameworks to use the modern Environment.ProcessId API.

  • Implements Environment.ProcessId polyfill for pre-.NET 5.0 frameworks
  • Adds comprehensive test coverage for the new polyfill in the Net50 test suite
  • Follows the existing polyfill pattern used in the codebase (e.g., similar to Environment.ProcessPath in Net60)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
PolyShim/Net50/Environment.cs Adds ProcessId property that returns the current process ID using Process.GetCurrentProcess().Id
PolyShim.Tests/Net50/EnvironmentTests.cs Adds unit test to verify ProcessId returns the correct value
PolyShim.Tests/Net60/EnvironmentTests.cs Adds unit test for ProcessPath (appears to be related cleanup/organization)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (bd63973) to head (5430620).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #25   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants