Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 16, 2025 14:35
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds polyfills for operating system detection methods from .NET 5.0, making them available to earlier framework versions. The implementation provides backward compatibility for OS platform checks and version detection.

  • Adds OperatingSystem.IsFreeBSD(), IsLinux(), IsMacOS(), IsWindows(), and IsWindowsVersionAtLeast() methods
  • Introduces OSPlatform.FreeBSD property for .NET Core 3.0 and earlier
  • Includes a placeholder OperatingSystem class for .NET Core 2.0 and earlier frameworks

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
PolyShim/Net50/OperatingSystem.cs Implements polyfills for OperatingSystem.IsXyz() methods and IsWindowsVersionAtLeast() for pre-.NET 5.0 frameworks
PolyShim/NetCore30/OSPlatform.cs Adds OSPlatform.FreeBSD property polyfill for .NET Core 3.0 and earlier
PolyShim/NetCore20/OperatingSystem.cs Provides placeholder OperatingSystem class for .NET Core 2.0 and earlier to support extension methods
PolyShim/NetCore20/SystemException.cs Adds blank line for code formatting consistency
PolyShim.Tests/Net50/OperatingSystemTests.cs Adds tests for IsLinux(), IsMacOS(), and IsWindows() methods across different platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (d137db0) to head (ae9085a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #34   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tyrrrz Tyrrrz merged commit 0b0489b into master Nov 16, 2025
3 checks passed
@Tyrrrz Tyrrrz deleted the operating-system branch November 16, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants