-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add polyfills for Convert.ToHexString[Lower](...) and Convert.FromHexString(...)
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds polyfills for hexadecimal string conversion methods from the Convert class, enabling these .NET 5.0 and .NET 9.0 APIs to be used in earlier framework versions.
- Implements
Convert.FromHexString,Convert.ToHexString(NET 5.0 APIs) - Implements
Convert.ToHexStringLower(NET 9.0 APIs) - Includes comprehensive test coverage for the new polyfills
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| PolyShim/Signatures.md | Updated documentation to include 5 new Convert methods with correct version annotations |
| PolyShim/Net50/Convert.cs | Implements FromHexString and ToHexString polyfills with custom hex conversion logic using bitwise operations |
| PolyShim/Net90/Convert.cs | Implements ToHexStringLower by delegating to ToHexString and applying ToLowerInvariant() |
| PolyShim.Tests/Net50/ConvertTests.cs | Adds tests for hex string encoding/decoding including error cases for invalid input |
| PolyShim.Tests/Net90/ConvertTests.cs | Adds tests for lowercase hex string conversion with various input scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.