Skip to content

Upgrade to polkadot v0.9.26 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CertainLach wants to merge 11 commits into from
Closed

Upgrade to polkadot v0.9.26 #445

CertainLach wants to merge 11 commits into from

Conversation

@CertainLach
Copy link
Member

@CertainLach CertainLach commented Jul 19, 2022

Superseeds #431

@CertainLach
Copy link
Member Author

CertainLach commented Jul 19, 2022

Includes #441, but for upgraded substrate

@CertainLach
Copy link
Member Author

CertainLach commented Jul 20, 2022

Тут требуется обернуть вызов в with_transactional, т.к атрибут #[transactional] мы убрали с вызовов в polkadot v0.9.25

unique-chain/pallets/scheduler/src/lib.rs

Line 441 in 566036f

let r = T::CallExecutor::dispatch_call(sender, call.clone());

В оригинальном substrate так не делают, т.к там используют call.dispatch, а у нас всё идёт через extrinsic.apply, а потому

unique-chain/runtime/opal/src/lib.rs

Line 1003 in 566036f

extrinsic.apply::<Runtime>(&dispatch_info, 0)

CertainLach added 10 commits July 21, 2022 10:36
@CertainLach
build(dep): upgrade polkadot to v0.9.25
04c0934 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
refactor: switch to new prefix removal methods
5d9665e 
New methods allows to call `remove_prefix` with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
refactor(node): use export-genesis state from cumulus
03cdd4a 
We had our implementation for some reason, however it is now broken, and
I see no reason to keep it, as upstream implements exact same options

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
refactor: remove #[transactional] from extrinsics
460acb3 
Every extrinsic now runs in transaction implicitly, and
`#[transactional]` on pallet dispatchable is now meaningless

Upstream-Change: paritytech/substrate#10806
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
fix(runtime): add missing config keys
93792bc 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
test: upgrade dependencies
5f782ab 
Old polkadot.js is no longer able to generate types for upgraded node

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
test: regenerate types
d32cde8 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
build(dep): upgrade polkadot to v0.9.26
50a343e 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
fix(runtime): add missing config keys
430decb 
New parity changes expect that System pallet has id 0, as it is declared
in most parachains

Because pallet id was changed, tx_version was increased, because old
transactions will not work with new version of chain

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
fix(node): use jsonrpsee with unknown fields patch
0f9e115 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach CertainLach force-pushed the feature/upgrade-polkadot-v0.9.26 branch from e1fdbe5 to 0f9e115 Compare July 21, 2022 08:38
@CertainLach
Copy link
Member Author

CertainLach commented Jul 21, 2022

Hey, seems like you need to have changelog and version bumps for your PR?

Don't worry, i've got you covered, if you have proper commit messages, then changelog generated by me should be okay for you

Changes

After your confirmation, I will append the following entries to changelogs of packages:

unique-runtime-common v0.9.25 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-unique-scheduler v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-structure v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-rmrk-core v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Remove #[transactional] from extrinsics 460acb3

Every extrinsic now runs in transaction implicitly, and
#[transactional] on pallet dispatchable is now meaningless

Upstream-Change: paritytech/substrate#10806

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-unique v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Remove #[transactional] from extrinsics 460acb3

Every extrinsic now runs in transaction implicitly, and
#[transactional] on pallet dispatchable is now meaningless

Upstream-Change: paritytech/substrate#10806

  • refactor: Switch to new prefix removal methods 5d9665e

New methods allows to call remove_prefix with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490

  • build: Upgrade polkadot to v0.9.25 04c0934

up-data-structs v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-rmrk-equip v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Remove #[transactional] from extrinsics 460acb3

Every extrinsic now runs in transaction implicitly, and
#[transactional] on pallet dispatchable is now meaningless

Upstream-Change: paritytech/substrate#10806

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-refungible v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Switch to new prefix removal methods 5d9665e

New methods allows to call remove_prefix with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490

  • build: Upgrade polkadot to v0.9.25 04c0934

evm-coder v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

up-rpc v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

opal-runtime v0.9.25 (Patch bump)

Bugfixes

New parity changes expect that System pallet has id 0, as it is declared
in most parachains

Because pallet id was changed, tx_version was increased, because old
transactions will not work with new version of chain

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-evm-contract-helpers v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

tests v0.1.1 (Patch bump)

Bugfixes

New parity changes expect that System pallet has id 0, as it is declared
in most parachains

Because pallet id was changed, tx_version was increased, because old
transactions will not work with new version of chain

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

uc-rpc v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-evm-coder-substrate v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

unique-node v0.9.25 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Use export-genesis state from cumulus 03cdd4a

We had our implementation for some reason, however it is now broken, and
I see no reason to keep it, as upstream implements exact same options

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-evm-migration v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Remove #[transactional] from extrinsics 460acb3

Every extrinsic now runs in transaction implicitly, and
#[transactional] on pallet dispatchable is now meaningless

Upstream-Change: paritytech/substrate#10806

  • build: Upgrade polkadot to v0.9.25 04c0934

rmrk-rpc v0.0.2 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-fungible v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Switch to new prefix removal methods 5d9665e

New methods allows to call remove_prefix with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-nonfungible v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Switch to new prefix removal methods 5d9665e

New methods allows to call remove_prefix with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-common v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • refactor: Switch to new prefix removal methods 5d9665e

New methods allows to call remove_prefix with limit multiple times
in the same block
However, we don't use prefix removal limits, so upgrade is
straightforward

Upstream-Change: paritytech/substrate#11490

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-evm-transaction-payment v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

pallet-inflation v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

unique-rpc v0.1.1 (Patch bump)

Other changes

  • build: Upgrade polkadot to v0.9.26 50a343e

  • build: Upgrade polkadot to v0.9.25 04c0934

Bumps

I may not be able to describe reason for bump, but they should be required:

unique-runtime-common 0.9.24 -> 0.9.25

  • changelog generator decided to bump to Patch

pallet-unique-scheduler 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-structure 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-rmrk-core 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-unique 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

up-data-structs 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-rmrk-equip 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-refungible 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

evm-coder 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

up-rpc 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

opal-runtime 0.9.24 -> 0.9.25

  • changelog generator decided to bump to Patch

pallet-evm-contract-helpers 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

tests 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

uc-rpc 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-evm-coder-substrate 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

unique-node 0.9.24 -> 0.9.25

  • changelog generator decided to bump to Patch

pallet-evm-migration 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

rmrk-rpc 0.0.1 -> 0.0.2

  • changelog generator decided to bump to Patch

pallet-fungible 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-nonfungible 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-common 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-evm-transaction-payment 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

pallet-inflation 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

unique-rpc 0.1.0 -> 0.1.1

  • changelog generator decided to bump to Patch

@CertainLach CertainLach requested a review from kozyrevdev July 21, 2022 08:43
@CertainLach
Copy link
Member Author

CertainLach commented Jul 21, 2022

Прогнал генератор чейнжлогов (см. сообщение и последний коммит), перед мержом его потребуется снова прогнать, т.к версии там будут уже другие

kozyrevdev
kozyrevdev suggested changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kozyrevdev kozyrevdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CertainLach нужно дообновиться https://github.com/paritytech/polkadot/tree/release-v0.9.26-1

@mrshiposha mrshiposha mentioned this pull request Aug 16, 2022
Closed
@mrshiposha mrshiposha closed this Aug 16, 2022
@kozyrevdev kozyrevdev deleted the feature/upgrade-polkadot-v0.9.26 branch November 14, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kozyrevdev kozyrevdev kozyrevdev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CertainLach @kozyrevdev @mrshiposha