feat: add tokenMap to schema #420

lynnshaoyu · 2023-07-05T16:11:24Z

Add tokenMap to schema so we can add a map in default-token-list, and the other token list repos. Useful to avoid re-declaring token constants in downstream repos (like smart order router, interface).

JFrankfurt · 2023-07-05T17:12:06Z

have you considered using ExtensionMap?

          "x-bridged-addresses-by-chain": {
            "1": {
              "bridgeAddress": "0x4200000000000000000000000000000000000010",
              "tokenAddress": "0x4200000000000000000000000000000000000010"
            }
          }

(see example on line 92)

lynnshaoyu · 2023-07-05T19:54:47Z

have you considered using ExtensionMap?

          "x-bridged-addresses-by-chain": {
            "1": {
              "bridgeAddress": "0x4200000000000000000000000000000000000010",
              "tokenAddress": "0x4200000000000000000000000000000000000010"
            }
          }

(see example on line 92)

I updated the schema with types for propertyNames and additionalProperties that I think makes more sense than using ExtensionMap?

cgkol

Looks good!

Imebeez

👍

Imebeez

👌

Alexyft07

Please someone should help me out on this👆

Imebeez · 2023-07-13T08:28:47Z

G

lynnshaoyu · 2023-07-14T16:36:47Z

@Alexyft07 what do you need help with?

Imebeez

H

Imebeez · 2023-07-16T17:49:35Z

src/tokenlist.schema.json

+      },
+      "examples": [
+        {
+          "4_0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984":  {


Imebeez

Deacon77

I'm learning hope I didn't do a bad job

Deacon77 · 2023-08-06T10:43:53Z

package.json

  },
  "description": "📚 The Token Lists specification",
-  "version": "1.0.0-beta.31",
+  "version": "1.0.0-beta.32",


Deacon77 · 2023-08-11T10:04:25Z

package.json

    "email": "[email protected]",
    "url": "https://uniswap.org"
  },
  "description": "📚 The Token Lists specification",


Deacon77 · 2023-08-11T10:06:33Z

src/tokenlist.schema.json

+            "name": "Uniswap",
+            "address": "0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984",


Deacon77 · 2023-08-11T13:05:56Z

package.json

    "email": "[email protected]",
    "url": "https://uniswap.org"
  },
  "description": "📚 The Token Lists specification",


Deacon77 · 2023-08-11T13:06:10Z

package.json

    "url": "https://uniswap.org"
  },
  "description": "📚 The Token Lists specification",
-  "version": "1.0.0-beta.31",


Deacon77 · 2023-08-18T06:07:40Z

src/tokenlist.schema.json

+            "symbol": "UNI",
+            "decimals": 18,
+            "chainId": 4,
+            "logoURI": "ipfs://QmXttGpZrECX5qCyXbBQiqgQNytVGeZW5Anewvh2jc4psg"


Deacon77 · 2023-08-18T06:07:49Z

src/tokenlist.schema.json

+          }
+        }
+      ]
+    },


Deacon77 · 2023-08-18T06:08:47Z

package.json

  "author": {
    "name": "Uniswap Labs",
    "email": "[email protected]",
    "url": "https://uniswap.org"


Deacon77 · 2023-08-25T10:57:18Z

package.json

    "url": "https://uniswap.org"
  },
  "description": "📚 The Token Lists specification",
-  "version": "1.0.0-beta.31",


Deacon77 · 2023-08-25T22:12:18Z

package.json

    "url": "https://uniswap.org"
  },
  "description": "📚 The Token Lists specification",
-  "version": "1.0.0-beta.31",


Rebelhdxx · 2023-09-12T17:02:16Z

So I need to add like bumps and rat stuff like that, so I just request another coin with more words to it, so and make sure it's not already been done in the net work learning by myself I just learned how to use these comments mate now feel free to give me any constructive criticism as much obliged thank you

cyny39 · 2023-09-12T18:29:17Z

#420

Bbjj88h

Approve merging please

Imebeez

drewgitgit · 2024-10-28T01:10:32Z

Thanks

drewgitgit

Thanks

suss56

drewgitgit

Ready

drewgitgit

Cash money

suss56

J

KingRobZombie-CEO

Nice

drewgitgit · 2025-02-07T10:54:31Z

great

Armanidashh

1

KingRobZombie-CEO

👍🏽

drewgitgit

Nice

Imebeez

noelportillo

I have to get my coins

noelportillo

So what are we supposed do with this

noelportillo

Did they have any of that stuff at all before

drewgitgit · 2025-07-22T17:24:31Z

What Sent from my iPhoneOn Jul 22, 2025, at 8:18 AM, Noel Portillo ***@***.***> wrote: @noelportillo commented on this pull request. Did they have any of that stuff at all before —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

noelportillo

Very nice work

kikiki1378 · 2025-06-25T19:51:12Z

package.json

  "author": {
    "name": "Uniswap Labs",
    "email": "[email protected]",
    "url": "https://uniswap.org"


kikiki1378 · 2025-06-25T19:51:13Z

package.json

  "author": {
    "name": "Uniswap Labs",
    "email": "[email protected]",
    "url": "https://uniswap.org"


kikiki1378 · 2025-06-25T19:51:13Z

package.json

  "author": {
    "name": "Uniswap Labs",
    "email": "[email protected]",
    "url": "https://uniswap.org"


noelportillo

Perfect

suss56 · 2025-08-26T22:37:49Z

package.json

  "description": "📚 The Token Lists specification",
-  "version": "1.0.0-beta.31",
+  "version": "1.0.0-beta.32",
  "license": "MIT",


kikiki1378

I'll

init

b0422e0

lynnshaoyu requested review from JFrankfurt and cbachmeier July 5, 2023 16:11

lynnshaoyu mentioned this pull request Jul 5, 2023

[WIP] feat: add tokenMap Uniswap/default-token-list#1620

Closed

lynnshaoyu requested review from andysmith415, cgkol and mikeki July 5, 2023 18:17

add more detail to tokenMap schema

b3f1d4a

lynnshaoyu closed this Jul 5, 2023

lynnshaoyu reopened this Jul 5, 2023

bump pkg version

aa6d76f

cgkol approved these changes Jul 5, 2023

View reviewed changes

lynnshaoyu merged commit 395b5d6 into main Jul 5, 2023

lynnshaoyu deleted the update_schema_for_token_map branch July 5, 2023 21:18

lynnshaoyu mentioned this pull request Jul 5, 2023

fix: update types to include tokenMap #421

Merged

Imebeez reviewed Jul 6, 2023

View reviewed changes

Alexyft07 reviewed Jul 12, 2023

View reviewed changes

krasiva711 mentioned this pull request Jul 16, 2023

https://raw.githubusercontent.com/The-Blockchain-Association/sec-notice-list/master/ba-sec-list.json #404

Open

Imebeez reviewed Jul 16, 2023

View reviewed changes

Imebeez reviewed Jul 21, 2023

View reviewed changes

kaldikald mentioned this pull request Aug 8, 2023

Add tokenMap to schema so we can add a map in default-token-list, and the other token list repos. Useful to avoid re-declaring token constants in downstream repos (like smart order router, interface). kaldikald/assets#2

Closed

Deacon77 reviewed Aug 25, 2023

View reviewed changes

ujerry582 mentioned this pull request Aug 27, 2023

This should've been done in https://github.com/Uniswap/token-lists/pull/420 , but overlooked this and updating the schemas in this PR. justswaporg/justlists#3892

Closed

Bbjj88h reviewed Sep 7, 2024

View reviewed changes

Bbjj88h approved these changes Sep 7, 2024

View reviewed changes

Imebeez reviewed Sep 8, 2024

View reviewed changes

vit870 approved these changes Sep 28, 2024

View reviewed changes

Foxsenrubas mentioned this pull request Oct 7, 2024

428d965a5ad8e642025e75764e6d0af6003b93df spdx/license-list-XML#2582

Closed

9764319764319764 mentioned this pull request Oct 18, 2024

395b5d6a997a013a24a51fdc612b1f6085378fb4 Uniswap/token-list-bridge-utils#125

Open

drewgitgit reviewed Oct 28, 2024

View reviewed changes

suss56 reviewed Jan 9, 2025

View reviewed changes

drewgitgit reviewed Jan 10, 2025

View reviewed changes

drewgitgit reviewed Jan 12, 2025

View reviewed changes

suss56 reviewed Jan 12, 2025

View reviewed changes

KingRobZombie-CEO reviewed Jan 31, 2025

View reviewed changes

Armanidashh reviewed Feb 23, 2025

View reviewed changes

Zayarlin507 approved these changes Feb 23, 2025

View reviewed changes

KingRobZombie-CEO reviewed Feb 26, 2025

View reviewed changes

drewgitgit reviewed Feb 27, 2025

View reviewed changes

Imebeez reviewed Apr 8, 2025

View reviewed changes

Kamicio1234 approved these changes Jul 18, 2025

View reviewed changes

noelportillo reviewed Jul 22, 2025

View reviewed changes

kikiki1378 reviewed Jul 24, 2025

View reviewed changes

noelportillo reviewed Aug 23, 2025

View reviewed changes

suss56 reviewed Aug 26, 2025

View reviewed changes

package.json

"description": "📚 The Token Lists specification",

"version": "1.0.0-beta.31",

"version": "1.0.0-beta.32",

"license": "MIT",

Copy link

suss56 Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kamicio1234 approved these changes Aug 31, 2025

View reviewed changes

kikiki1378 reviewed Sep 4, 2025

View reviewed changes

		"name": "Uniswap",
		"address": "0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984",

feat: add tokenMap to schema #420

feat: add tokenMap to schema #420

Uh oh!

Conversation

lynnshaoyu commented Jul 5, 2023

Uh oh!

JFrankfurt commented Jul 5, 2023

Uh oh!

lynnshaoyu commented Jul 5, 2023

Uh oh!

cgkol left a comment

Choose a reason for hiding this comment

Uh oh!

Imebeez left a comment

Choose a reason for hiding this comment

Uh oh!

Imebeez left a comment

Choose a reason for hiding this comment

Uh oh!

Alexyft07 left a comment

Choose a reason for hiding this comment

Uh oh!

Imebeez commented Jul 13, 2023

Uh oh!

lynnshaoyu commented Jul 14, 2023

Uh oh!

Imebeez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Imebeez left a comment

Choose a reason for hiding this comment

Uh oh!

Deacon77 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rebelhdxx commented Sep 12, 2023

Uh oh!

cyny39 commented Sep 12, 2023

Uh oh!

Bbjj88h left a comment

Choose a reason for hiding this comment

Uh oh!

suss56 left a comment •

edited

Loading