Skip to content

Avoid putting links to all upstream PRs in the description #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshpeterson merged 1 commit into from
Dec 3, 2021
Merged

Avoid putting links to all upstream PRs in the description #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid putting links to all upstream PRs in the description 
The default pull request description (from the `--fill` argument) will
put a reference to each upstream pull request in our pull request
description. That will in turn cause Github to add an event on the
upstream PR indicating that our sync PR references it.

This is unnecessary noise, so instead use a stock title and body for our
sync pull requests.
  • Loading branch information
Josh Peterson committed Dec 2, 2021
commit 082048ac8127a3fba0486ad6d17925e67521e5c8
2 changes: 1 addition & 1 deletion .yamato/scripts/update_from_upstream.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ rm .githubtoken
git remote set-url origin $GIT_REPOSITORY_URL

# Create a pull request back to unity-main
gh pr create --fill
gh pr create --title "Sync with upstream main branch" --body "This is an automatically generated pull request to merge changes from the upstream main branch."

# For some unknown reason we often see this error from Github CLI:
#
Expand Down