Skip to content

v1: Remove style panel on Image core block #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braican merged 11 commits into from
Feb 23, 2023
Merged

v1: Remove style panel on Image core block #3

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e7ef32f
Remove style picker from core/image block
Feb 15, 2023
0e4fc39
Remove style picker from core/button block
Feb 15, 2023
f2b2f5e
Revert "Remove style picker from core/button block"
Feb 15, 2023
9be1e36
Remove hard-coded block style names in favor of array
Feb 21, 2023
4d98001
Add documentation to image registerFormatType
Feb 21, 2023
b38b124
Adjust comment
Feb 21, 2023
3255662
Add enable_block_styles as configuration option
Feb 21, 2023
c795b83
Little syntax updates
braican Feb 22, 2023
89a3f6b
Linting
braican Feb 23, 2023
30e71a2
Cleanup
braican Feb 23, 2023
24c7049
Readme
braican Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting
  • Loading branch information
@braican
braican committed Feb 23, 2023
commit 89a3f6b4e3128915e902fb691d34532f205ee545
18 changes: 9 additions & 9 deletions includes/Meta/AttachmentCredit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ class AttachmentCredit {
*/
private $attachment_fields = array(
array(
'id' => 'credit',
'label' => 'Credit',
'input' => 'text',
'helps' => 'Provide credit to the creator',
'id' => 'credit',
'label' => 'Credit',
'input' => 'text',
'helps' => 'Provide credit to the creator',
'single' => true,
)
),
);

/**
Expand All @@ -35,7 +35,7 @@ public static function register() {
$attachment_credit = new self();

add_filter( 'attachment_fields_to_edit', array( $attachment_credit, 'register_edit_fields' ), 10, 2 );
add_filter( 'attachment_fields_to_save', array( $attachment_credit, 'handle_save_fields'), 10, 2 );
add_filter( 'attachment_fields_to_save', array( $attachment_credit, 'handle_save_fields' ), 10, 2 );

add_action( 'rest_api_init', array( $attachment_credit, 'register_rest_fields' ) );
}
Expand Down Expand Up @@ -72,7 +72,7 @@ public function register_edit_fields( $fields, $post ) {
* @param array $post Array of post data.
* @param array $attachment Attachment metadata.
*
* @return void
* @return array
*/
public function handle_save_fields( $post, $attachment ) {
foreach ( $this->attachment_fields as $field ) {
Expand All @@ -93,12 +93,12 @@ public function handle_save_fields( $post, $attachment ) {
* @return void
*/
public function register_rest_fields() {
foreach ($this->attachment_fields as $field) {
foreach ( $this->attachment_fields as $field ) {
register_rest_field(
'attachment',
$field['id'],
array(
'get_callback' => function($object) use ($field) {
'get_callback' => function( $object ) use ( $field ) {
return get_post_meta( $object['id'], $field['id'], $field['single'] );
},
'update_callback' => null,
Expand Down