Skip to content

encodeURIComponent rather than encodeURI #32

@sebastiankade

Description

@sebastiankade

Hey @Urigo,

When constructing the embedly post you're using encodeURI() but really you should be using encodeURIComponent() as you are putting the encoded string as a query param.

This results in some urls failing to embed e.g. below:
https://www.google.com/maps/@45.5067683,-122.6069459,11z

Cheers
Sebastian

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions