feat(camera_web): add camera options #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Jul 8, 2021
ditman
reviewed
Jul 8, 2021
ditman
reviewed
Jul 9, 2021
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM, My only specific concern is that the FacingMode constraint definition is a little bit too complex (compared to the VideoSize constraint, which also has an "ideal" value).
Also: why is the VideoConstraints toJson async? It doesn't seem to need to be!
One last thing about naming of classes in this file, I'd add the "Constraint" surname to those that don't have it already: FacingModeConstraint and VideoSizeConstraint, that way it's very clear that we're creating CameraOptions from BlahBlahConstraint objects.
ditman
approved these changes
Jul 13, 2021
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
This LGTM! Powerful enough to express whatever we need, and easily extensible. 🚀
Author
|
Closing, moved to flutter/plugins#4164. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getUserMedia.Type of Change