Cba 267 session refresh update #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Freeswitch behavior when passively using session-timers. By passively, we mean that FS is NOT requiring that session-timers be used for the dialog, but the other party IS requiring that they be used ( and that FS act as the refresher ).
The issue we were facing was when FS was acting as the refresher, it would only use INVITE as the refresher method. In a bridged context, the session-refresh INVITE would go out without SDP, and then Freeswitch would ACK the 200/SDP without SDP, causing the other party to object to the lack of SDP.
FS dev had introduced a new SIP Profile param (
<param name="update-refresher" value="true"/>) but this was having no effect on FS behavior when used in a passive context. That is, the update-refresher would only be put to use if FS actively required session-timers rather, but would not use the update-refresher when accepting the requirement of the other party (passive).This change addresses that. When FS accepts an invite requiring the refresher=uas , or when FS receives a response requiring that refresher=uac, FS will appropriately use the update method for session refresh.