fix: ESM build #630
Merged
fix: ESM build #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESM build is not usable in strict tools because the file is named `index.module.js` and the package.json indicates that `.js` files are CommonJS rather than ESM. It seems a pretty simple change to the build configuration to have it be named `index.module.mjs` instead.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Owner
|
Thanks! |
|
🚀 PR was released in |
Owner
|
@all-contributors add @anomiex for infrastructure |
Contributor
|
I've put up a pull request to add @anomiex! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESM build is not usable in strict tools because the file is named
index.module.jsand the package.json indicates that.jsfiles are CommonJS rather than ESM.It seems a pretty simple change to the build configuration to have it be named
index.module.mjsinstead.Fixes #490