Adding in script for Oracle RBAC work #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexoelke
force-pushed
the
oracleExamples
branch
from
6c5c8c2 to
2d8a193
Compare
yougotborked
approved these changes
Dec 19, 2023
rkennedy
previously approved these changes
Jan 3, 2024
Collaborator
rkennedy
left a comment
rkennedy
left a comment
There was a problem hiding this comment.
Looks fine to me. There are some things that I think could be better, but I think it's on par with the rest of what we've published.
| # Cred? if doesn't already exist | ||
| # register creds | ||
|
|
||
| ## The script can be run with Python 3.5 or higher version. |
Collaborator
There was a problem hiding this comment.
FYI, Python 3.5 reached EOL over three years ago.
Collaborator
Author
There was a problem hiding this comment.
Yeah I'm not sure if we want to update the statement at the top to what it was developed with? It'll probably run with 3.5 but yeah I get its outdated.
alexoelke
force-pushed
the
oracleExamples
branch
from
2d8a193 to
b5b92f5
Compare
alexoelke
force-pushed
the
oracleExamples
branch
from
b5b92f5 to
7a444a1
Compare
rkennedy
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.