refactor: defined runCommandFile for SystemShell#68
Closed
alestiago wants to merge 1 commit intorefactor/enhanced-enumfrom
Closed
refactor: defined runCommandFile for SystemShell#68alestiago wants to merge 1 commit intorefactor/enhanced-enumfrom
alestiago wants to merge 1 commit intorefactor/enhanced-enumfrom
Conversation
alestiago
requested review from
erickzanardo,
felangel,
renancaraujo and
wolfenrain
as code owners
alestiago
added
the
refactor
renancaraujo
suggested changes
May 10, 2023
Contributor
renancaraujo
left a comment
renancaraujo
left a comment
There was a problem hiding this comment.
What is the argument for this change?
The completion configuration class exists to contain the parameters to link a shell completion system with a client application. In other words: everything that involves files, its paths and content that concern the installation of completion scripts should be on ShellCompletionConfiguration.
The system shell enum is used across the parser side too.
| logger.info( | ||
| 'Adding dart cli completion config entry ' | ||
| 'to $_shellRCFilePath', | ||
| 'to ${shellRunCommandFile.path}', |
Contributor
There was a problem hiding this comment.
What good is having run command doing here? Most people know those files as RC files. Unnecessary change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Uses enhanced enumeration feature to move the logic from
CompletionInstallationthat locates an RC file from the a shell toSystemShell.Type of Change