feat(very_good_core): add linux platform support#347
Open
Crdzbird wants to merge 5 commits intoVeryGoodOpenSource:mainfrom
Open
feat(very_good_core): add linux platform support#347Crdzbird wants to merge 5 commits intoVeryGoodOpenSource:mainfrom
Crdzbird wants to merge 5 commits intoVeryGoodOpenSource:mainfrom
Conversation
Adds the necessary files and configuration to support building and running the application on Linux. Introduces a Linux application ID model, CMake build scripts, Flutter plugin registration, and application runner setup.
Crdzbird
changed the title
Crdzbird
changed the title
Member
marcossevilla
left a comment
marcossevilla
left a comment
There was a problem hiding this comment.
can we also remove the files related to very_good_flame_game? thanks! :)
Member
There was a problem hiding this comment.
should we make this more generic like app.cc/app.h? or use the {{project_name}} var?
Contributor
Author
There was a problem hiding this comment.
related to the change on name, I'll vote to leave it as it is, since flutter by default generates it when running flutter create demo_app, which in this case on linux it'll always be my_application.c and the bridge my_application.h.
marcossevilla
changed the title
Updates the application class name from MyApplication to Application for consistency and clarity. Refactors related files and code to reflect the new naming convention.
Member
erickzanardo
left a comment
erickzanardo
left a comment
There was a problem hiding this comment.
Does this supports flavors? The reason that Linux wasn't in the very good core template was because that platform didn't supported flavors and adding it would make it inconsistent with the other platforms
Comment on lines
+17
to
+25
| https://github.com/waqas028/Document_Scanner_CMP | ||
|
|
||
| https://github.com/Coding-Meet/TextToSpeech-CMP | ||
|
|
||
| https://github.com/Debanshu777/XCalendar | ||
|
|
||
| https://github.com/thejohnsondev/PassGuard-Multiplatform | ||
|
|
||
| https://github.com/pksunny/flutter-ui-and-animations No newline at end of file |
| static void my_application_activate(GApplication* application) { | ||
| MyApplication* self = MY_APPLICATION(application); | ||
| static void application_activate(GApplication* application) { | ||
| Application* self = MY_APPLICATION(application); |
Member
There was a problem hiding this comment.
Suggested change
| Application* self = MY_APPLICATION(application); | |
| Application* self = APPLICATION(application); |
| static gboolean my_application_local_command_line(GApplication* application, gchar*** arguments, int* exit_status) { | ||
| MyApplication* self = MY_APPLICATION(application); | ||
| static gboolean application_local_command_line(GApplication* application, gchar*** arguments, int* exit_status) { | ||
| Application* self = MY_APPLICATION(application); |
Member
There was a problem hiding this comment.
Suggested change
| Application* self = MY_APPLICATION(application); | |
| Application* self = APPLICATION(application); |
| static void my_application_startup(GApplication* application) { | ||
| //MyApplication* self = MY_APPLICATION(object); | ||
| static void application_startup(GApplication* application) { | ||
| //Application* self = MY_APPLICATION(object); |
Member
There was a problem hiding this comment.
should we remove these comments?
| static void my_application_dispose(GObject* object) { | ||
| MyApplication* self = MY_APPLICATION(object); | ||
| static void application_dispose(GObject* object) { | ||
| Application* self = MY_APPLICATION(object); |
Member
There was a problem hiding this comment.
Suggested change
| Application* self = MY_APPLICATION(object); | |
| Application* self = APPLICATION(application); |
| g_set_prgname(APPLICATION_ID); | ||
|
|
||
| return MY_APPLICATION(g_object_new(my_application_get_type(), | ||
| return MY_APPLICATION(g_object_new(application_get_type(), |
Member
There was a problem hiding this comment.
Suggested change
| return MY_APPLICATION(g_object_new(application_get_type(), | |
| return APPLICATION(g_object_new(application_get_type(), |
| MyApplication* my_application_new(); | ||
| Application* application_new(); | ||
|
|
||
| #endif // FLUTTER_MY_APPLICATION_H_ |
Member
There was a problem hiding this comment.
Suggested change
| #endif // FLUTTER_MY_APPLICATION_H_ | |
| #endif // FLUTTER_APPLICATION_H_ |
| #include <gtk/gtk.h> | ||
|
|
||
| G_DECLARE_FINAL_TYPE(MyApplication, my_application, MY, APPLICATION, | ||
| G_DECLARE_FINAL_TYPE(Application, application, MY, APPLICATION, |
Member
There was a problem hiding this comment.
Suggested change
| G_DECLARE_FINAL_TYPE(Application, application, MY, APPLICATION, | |
| G_DECLARE_FINAL_TYPE(Application, application, APPLICATION, |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds to the VG core the necessary files and configuration to support building and running the application on Linux.
Introduces a Linux application ID model, CMake build scripts, Flutter plugin registration, and application runner setup.
Description
Type of Change