Open
Conversation
This is for semantics (there should be 1 element with any ID) https://html.spec.whatwg.org/multipage/dom.html#global-attributes
I meant to do something like #eeeeee to begin with because #fefefe is just 254 instead of 255 rbg values (not a lot dimmer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A small UX gain, when I tried the theme out the bright white caught me off guard so I figured adding a default based on your browser settings would be a nice to have.
Features
@media prefers-color-schemevariable.localStorageand thedata-themeattribute) to toggle between the color schemes.Notable changes
Do note that in 37511ba I also change the ID attribute for the logo from
ghicontologoin order to have uniqueness as defined by the HTML standards and to also ensure I can change the GitHub Icon dynamically with thefilter: invert(100%);CSS.Formatting in f9d18ee and 948bfcc was done with prettier. Feel free to review code at 37511ba...948bfcc separately from 948bfcc...8bb8625.
End Result
Google Chrome
Firefox