Reject config with <html> in replaceWithChildrenElements as invalid#377
Merged
Reject config with <html> in replaceWithChildrenElements as invalid#377
Conversation
otherdaniel
reviewed
Mar 4, 2026
evilpie
commented
Mar 4, 2026
otherdaniel
approved these changes
Mar 4, 2026
Collaborator
otherdaniel
left a comment
otherdaniel
left a comment
There was a problem hiding this comment.
Looks good.
I think we need to also mention this at least once somewhere in the prose. E.g. in https://wicg.github.io/sanitizer-api/#invariants , maybe getting it's own bullet in the list following "Several conditions need to hold for a configuration to be valid:"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365.
We can't allow the replacement of the root
<html>element with multiple elements. So we reject any config that hasreplaceWithChildrenElements: ["html"].Preview | Diff