Use std::filesystem::path instead of string for file paths #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 5, 2023
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Looks like a good direction to me to do this gradually!
CI errors look a little worrying though in terms of cross-platform support for this API?
Member
Author
|
Switching to draft, Going to try a couple of things to maybe avoid compatibility issues... |
Contributor
|
This looks like a good first step toward supporting unicode paths on windows. Thanks. |
Member
Author
|
Closing this in favor of #5671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.